Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: editor: improve buffer stops and detectors visibility #5726

Merged
merged 1 commit into from
Nov 17, 2023
Merged

front: editor: improve buffer stops and detectors visibility #5726

merged 1 commit into from
Nov 17, 2023

Conversation

SarahBellaha
Copy link
Contributor

Closes #5596
Closes #5597

@SarahBellaha SarahBellaha added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules module:infra-editor Infra Edition labels Nov 16, 2023
@SarahBellaha SarahBellaha requested a review from a team as a code owner November 16, 2023 16:11
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (92904fa) 19.57% compared to head (0e7c5a5) 19.57%.
Report is 5 commits behind head on dev.

Files Patch % Lines
...lications/editor/tools/routeEdition/components.tsx 0.00% 11 Missing ⚠️
front/src/applications/editor/Editor.tsx 0.00% 3 Missing ⚠️
...src/applications/editor/tools/routeEdition/tool.ts 0.00% 1 Missing ⚠️
front/src/common/Map/Layers/Detectors.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                dev    #5726   +/-   ##
=========================================
  Coverage     19.57%   19.57%           
  Complexity     2326     2326           
=========================================
  Files           886      890    +4     
  Lines        106157   106125   -32     
  Branches       2576     2579    +3     
=========================================
- Hits          20777    20776    -1     
+ Misses        83871    83837   -34     
- Partials       1509     1512    +3
Flag Coverage Δ
front 8.32% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBellaha SarahBellaha changed the title Sba/front/improve buffer stops and detectors visibility front: editor: improve buffer stops and detectors visibility Nov 16, 2023
Yohh
Yohh approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

clarani
clarani requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just can you remove the placeholder in the selection, so no layer is grey by default ? thanks :)

@SarahBellaha SarahBellaha force-pushed the sba/front/improve-buffer-stops-and-detectors-visibility branch from 7b08fac to f613363 Compare November 17, 2023 15:56
clarani
clarani approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested ✅

@SarahBellaha
front: editor: make tracksection layer not required for the route tool
0e7c5a5 
- front: editor: improve detectors visibility
@SarahBellaha SarahBellaha force-pushed the sba/front/improve-buffer-stops-and-detectors-visibility branch from f613363 to 0e7c5a5 Compare November 17, 2023 16:09
@SarahBellaha SarahBellaha added this pull request to the merge queue Nov 17, 2023
Merged via the queue into dev with commit ac12bcd Nov 17, 2023
@SarahBellaha SarahBellaha deleted the sba/front/improve-buffer-stops-and-detectors-visibility branch November 17, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yohh Yohh Yohh approved these changes

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:infra-editor Infra Edition
Projects
None yet
Milestone
No milestone
3 participants
@SarahBellaha @Yohh @clarani