Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: operationnalstudies: fix error not display for train update #5727

Merged
merged 1 commit into from
Nov 17, 2023
Merged

front: operationnalstudies: fix error not display for train update #5727

merged 1 commit into from
Nov 17, 2023

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Nov 16, 2023 •
edited
Loading

  • add catch to api call in SubmitConfUpdateTrainSchedules
  • add callSuccess variable to avoid succes if an error happens
  • add allowance convergence error translation

close #5570

@Yohh
front: operationnalstudies: fix error not display for train update
464ea38 
- add catch to api call in SubmitConfUpdateTrainSchedules
- add callSuccess variable to avoid succes if an error happens
- add allowance convergence error translation
@Yohh Yohh requested a review from a team as a code owner November 16, 2023 16:13
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (c482536) 19.62% compared to head (464ea38) 19.59%.
Report is 3 commits behind head on dev.

Files Patch % Lines
...geTrainSchedule/SubmitConfUpdateTrainSchedules.tsx 0.00% 32 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #5727      +/-   ##
============================================
- Coverage     19.62%   19.59%   -0.04%     
  Complexity     2326     2326              
============================================
  Files           886      886              
  Lines        105950   106116     +166     
  Branches       2576     2576              
============================================
- Hits          20795    20794       -1     
- Misses        83646    83813     +167     
  Partials       1509     1509
Flag Coverage Δ
front 8.32% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yohh Yohh mentioned this pull request Nov 16, 2023
Closed
@woshilapin woshilapin added the area:front Work on Standard OSRD Interface modules label Nov 17, 2023
@Yohh Yohh added this pull request to the merge queue Nov 17, 2023
Merged via the queue into dev with commit 5210eb2 Nov 17, 2023
4 of 5 checks passed
@Yohh Yohh deleted the yoh/front-operationalstudies-fix-error-not-displayed-when-adding-allowance-fails branch November 17, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainValls RomainValls RomainValls approved these changes

@Math-R Math-R Math-R approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't modify a train when adding some engineering allowance
4 participants
@Yohh @Math-R @RomainValls @woshilapin