Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix speed limit composition code selection #5728

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix speed limit composition code selection #5728

merged 1 commit into from
Nov 17, 2023

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Nov 16, 2023

Close #5720

@sim51 sim51 requested a review from a team as a code owner November 16, 2023 16:24
@sim51 sim51 enabled auto-merge November 16, 2023 16:27
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (6e7fc8d) 19.61% compared to head (f5757ef) 19.58%.
Report is 2 commits behind head on dev.

Files Patch % Lines
...src/applications/editor/components/LayersModal.tsx 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #5728      +/-   ##
============================================
- Coverage     19.61%   19.58%   -0.03%     
  Complexity     2326     2326              
============================================
  Files           886      886              
  Lines        105947   106096     +149     
  Branches       2576     2576              
============================================
- Hits          20777    20776       -1     
- Misses        83661    83811     +150     
  Partials       1509     1509
Flag Coverage Δ
front 8.33% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster changed the title front: editor - be able to select acomposition code #5720 front: editor - be able to select a composition code #5720 Nov 16, 2023
@flomonster flomonster changed the title front: editor - be able to select a composition code #5720 Fix speed limit composition code selection #5720 Nov 16, 2023
@flomonster flomonster changed the title Fix speed limit composition code selection #5720 Fix speed limit composition code selection Nov 16, 2023
clarani
clarani approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested ☑️

@sim51 sim51 added this pull request to the merge queue Nov 17, 2023
Merged via the queue into dev with commit 6b73c88 Nov 17, 2023
@sim51 sim51 deleted the bsi/issue-5720 branch November 17, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot see and edit speed sections
2 participants
@sim51 @clarani