Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add supplementary axis #5747

Merged
merged 1 commit into from
Nov 23, 2023
Merged

add supplementary axis #5747

merged 1 commit into from
Nov 23, 2023

Conversation

alexandredamiron
Copy link
Contributor

#fix #5725

@alexandredamiron alexandredamiron marked this pull request as ready for review November 20, 2023 15:57
@alexandredamiron alexandredamiron requested a review from a team as a code owner November 20, 2023 15:57
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (9da5c42) 19.63% compared to head (a515136) 19.62%.

Files Patch % Lines
...ult/components/SpeedSpaceChart/SpeedSpaceChart.tsx 0.00% 20 Missing ⚠️
...lt/components/ChartHelpers/enableInteractivity.tsx 0.00% 15 Missing ⚠️
.../simulationResult/components/SpaceCurvesSlopes.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5747      +/-   ##
============================================
- Coverage     19.63%   19.62%   -0.01%     
  Complexity     2332     2332              
============================================
  Files           908      908              
  Lines        107837   107865      +28     
  Branches       2626     2626              
============================================
  Hits          21169    21169              
- Misses        85109    85137      +28     
  Partials       1559     1559              
Flag Coverage Δ
front 8.63% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, left some comments

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you just need to rebase and squash your commits ✅

prettier ùod

slight optimisation for enableAes determination

optimize supp axes computation

remove comma
@alexandredamiron alexandredamiron added this pull request to the merge queue Nov 23, 2023
Merged via the queue into dev with commit 5332a7c Nov 23, 2023
6 of 7 checks passed
@alexandredamiron alexandredamiron deleted the adn/fix-5725 branch November 23, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag thought the curves/declivity graph makes curvatures and altitude disappear
3 participants