-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add supplementary axis #5747
add supplementary axis #5747
Conversation
83a4b37
to
43eba6b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5747 +/- ##
============================================
- Coverage 19.63% 19.62% -0.01%
Complexity 2332 2332
============================================
Files 908 908
Lines 107837 107865 +28
Branches 2626 2626
============================================
Hits 21169 21169
- Misses 85109 85137 +28
Partials 1559 1559
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, left some comments
front/src/modules/simulationResult/components/ChartHelpers/enableInteractivity.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/ChartHelpers/enableInteractivity.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/ChartHelpers/enableInteractivity.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/ChartHelpers/enableInteractivity.tsx
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/SpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceChart.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceChart.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, you just need to rebase and squash your commits ✅
prettier ùod slight optimisation for enableAes determination optimize supp axes computation remove comma
f09cf9a
to
a515136
Compare
#fix #5725