Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix timetable train selection #5818

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Nov 23, 2023

no train was selected after deleting the selected train

close #5811

@SharglutDev SharglutDev requested a review from a team as a code owner November 23, 2023 11:55
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6958130) 19.61% compared to head (ba5cc2c) 19.61%.
Report is 19 commits behind head on dev.

Files Patch % Lines
...tudies/components/Scenario/getSimulationResults.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5818      +/-   ##
============================================
- Coverage     19.61%   19.61%   -0.01%     
  Complexity     2332     2332              
============================================
  Files           907      909       +2     
  Lines        107662   107922     +260     
  Branches       2623     2627       +4     
============================================
+ Hits          21120    21168      +48     
- Misses        84986    85194     +208     
- Partials       1556     1560       +4     
Flag Coverage Δ
front 8.62% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

no train was selected after deleting the selected train
@SharglutDev SharglutDev force-pushed the pfn/front/fix-timetable-train-selection branch from 1219b0b to ba5cc2c Compare November 23, 2023 16:46
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested ✅

@SharglutDev SharglutDev added this pull request to the merge queue Nov 23, 2023
Merged via the queue into dev with commit 0295e00 Nov 23, 2023
@SharglutDev SharglutDev deleted the pfn/front/fix-timetable-train-selection branch November 23, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No train selected after deleting a train
2 participants