Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: editor: small ui improvements on infra error list #5829

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

nicolaswurtz
Copy link
Contributor

Before : large dynamic height modal, gray background + white background, no responsive top filters
After : fixed height modal, only errors scrolling, more concise top & responsive top filters

image
image

@nicolaswurtz nicolaswurtz added difficulty:good first issue Good for newcomers area:front Work on Standard OSRD Interface modules kind:design Work which come before an implementation ! labels Nov 23, 2023
@nicolaswurtz nicolaswurtz requested a review from a team as a code owner November 23, 2023 14:27
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 79 lines in your changes are missing coverage. Please review.

Comparison is base (d800049) 19.61% compared to head (8d1d199) 19.61%.

Files Patch % Lines
.../editor/components/InfraErrors/InfraErrorsList.tsx 0.00% 79 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5829      +/-   ##
============================================
- Coverage     19.61%   19.61%   -0.01%     
  Complexity     2332     2332              
============================================
  Files           907      907              
  Lines        107693   107696       +3     
  Branches       2623     2623              
============================================
  Hits          21124    21124              
- Misses        85013    85016       +3     
  Partials       1556     1556              
Flag Coverage Δ
front 8.60% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sim51 sim51 enabled auto-merge November 23, 2023 14:36
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

@sim51 sim51 added this pull request to the merge queue Nov 24, 2023
Merged via the queue into dev with commit 41df33e Nov 24, 2023
6 of 7 checks passed
@sim51 sim51 deleted the nwz/small-ui-improvements-on-editor-infra-errors-list branch November 24, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules difficulty:good first issue Good for newcomers kind:design Work which come before an implementation !
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants