-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: editor - Adding help on catenary tool #5834
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5834 +/- ##
============================================
- Coverage 19.70% 19.70% -0.01%
Complexity 2345 2345
============================================
Files 910 910
Lines 108075 108085 +10
Branches 2634 2634
============================================
Hits 21299 21299
- Misses 85216 85226 +10
Partials 1560 1560
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, left some comments (most of them for typo)
front/src/applications/editor/tools/rangeEdition/catenary/CatenaryEditionLayers.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/editor/tools/rangeEdition/components.tsx
Outdated
Show resolved
Hide resolved
f56ccc0
to
84368ad
Compare
Close #5371 Refacto the code of range tool, to avoid namings that are not generic to all tool only one range tool.
84368ad
to
b07ccfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Close #5371
Adding a text message when there is no linked track section on Catenary & speed section tool.
I also added some hint messages for catenary tool.