Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: editor - Adding help on catenary tool #5834

Merged
merged 1 commit into from
Nov 24, 2023
Merged

front: editor - Adding help on catenary tool #5834

merged 1 commit into from
Nov 24, 2023

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Nov 23, 2023

Close #5371

Adding a text message when there is no linked track section on Catenary & speed section tool.
I also added some hint messages for catenary tool.

@sim51 sim51 requested a review from a team as a code owner November 23, 2023 17:08
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 198 lines in your changes are missing coverage. Please review.

Comparison is base (b6ead5b) 19.70% compared to head (b07ccfb) 19.70%.

Files Patch % Lines
...lications/editor/tools/rangeEdition/components.tsx 0.00% 133 Missing ⚠️
...ls/rangeEdition/catenary/CatenaryEditionLayers.tsx 0.00% 22 Missing ⚠️
...rc/applications/editor/tools/rangeEdition/utils.ts 0.00% 15 Missing ⚠️
...cations/editor/tools/rangeEdition/tool-factory.tsx 0.00% 13 Missing ⚠️
...rc/applications/editor/tools/rangeEdition/types.ts 0.00% 11 Missing ⚠️
...Edition/speedSection/SpeedSectionEditionLayers.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5834      +/-   ##
============================================
- Coverage     19.70%   19.70%   -0.01%     
  Complexity     2345     2345              
============================================
  Files           910      910              
  Lines        108075   108085      +10     
  Branches       2634     2634              
============================================
  Hits          21299    21299              
- Misses        85216    85226      +10     
  Partials       1560     1560              
Flag Coverage Δ
front 8.63% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, left some comments (most of them for typo)

front/public/locales/fr/translation.json Outdated Show resolved Hide resolved
front/public/locales/fr/translation.json Outdated Show resolved Hide resolved
front/public/locales/fr/translation.json Outdated Show resolved Hide resolved
front/public/locales/fr/translation.json Outdated Show resolved Hide resolved
front/public/locales/en/translation.json Outdated Show resolved Hide resolved
front/public/locales/en/translation.json Outdated Show resolved Hide resolved
@sim51 sim51 force-pushed the bsi/issue-5371 branch 2 times, most recently from f56ccc0 to 84368ad Compare November 24, 2023 12:09
Close #5371

Refacto the code of range tool, to avoid namings that are not generic to
all tool
only one range tool.
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@clarani clarani added this pull request to the merge queue Nov 24, 2023
Merged via the queue into dev with commit 3141a01 Nov 24, 2023
6 of 7 checks passed
@clarani clarani deleted the bsi/issue-5371 branch November 24, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: Create new Electrification
3 participants