Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: parallelise errors layer generation #5847

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

younesschrifi
Copy link
Contributor

close #5516

@younesschrifi younesschrifi requested a review from a team as a code owner November 24, 2023 11:16
@younesschrifi younesschrifi force-pushed the yci/speed-up-layer-generation branch 4 times, most recently from b41e0d8 to 92a5a29 Compare November 24, 2023 11:38
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6ead5b) 19.70% compared to head (f2495df) 19.72%.
Report is 8 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5847      +/-   ##
============================================
+ Coverage     19.70%   19.72%   +0.01%     
  Complexity     2345     2345              
============================================
  Files           910      910              
  Lines        108075   108097      +22     
  Branches       2634     2634              
============================================
+ Hits          21299    21319      +20     
- Misses        85216    85218       +2     
  Partials       1560     1560              
Flag Coverage Δ
editoast 68.94% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the yci/speed-up-layer-generation branch 2 times, most recently from b531bc7 to 57e40b4 Compare November 24, 2023 12:02
editoast/src/generated_data/error/mod.rs Outdated Show resolved Hide resolved
editoast/src/generated_data/error/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Could you add some benchmark information in the PR description to see how effective the modification is.

editoast/src/generated_data/error/mod.rs Outdated Show resolved Hide resolved
@younesschrifi younesschrifi force-pushed the yci/speed-up-layer-generation branch 3 times, most recently from c68c840 to efebb8c Compare November 27, 2023 09:23
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! Thanks for your PR.

@younesschrifi younesschrifi added this pull request to the merge queue Nov 28, 2023
Merged via the queue into dev with commit e18285d Nov 28, 2023
10 checks passed
@younesschrifi younesschrifi deleted the yci/speed-up-layer-generation branch November 28, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve edition save endpoint performance
3 participants