Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: rewrite kp label layer #5876

Merged
merged 2 commits into from
Nov 28, 2023
Merged

front: rewrite kp label layer #5876

merged 2 commits into from
Nov 28, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Nov 27, 2023

closes #5797

The problem was that if a source is of type geojson, it can not receive a source-layer.

In this PR I:

  • renamed and modified a bit the configKPLabelLayer function to harmonize it with the other layers + remove the source layer if not needed
  • in SpeedSectionEditionLayers, modified the code to have always the 2 sources
  • renamed the SNCF_PSL and SNCF_PSL_SIGNS files

@clarani clarani requested a review from a team as a code owner November 27, 2023 13:08
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (b6ead5b) 19.70% compared to head (09ff38e) 19.70%.
Report is 19 commits behind head on dev.

Files Patch % Lines
...Edition/speedSection/SpeedSectionEditionLayers.tsx 0.00% 33 Missing ⚠️
front/src/common/Map/Layers/KPLabel.ts 0.00% 20 Missing ⚠️
...src/common/Map/Layers/extensions/SNCF/PSLSigns.tsx 0.00% 9 Missing ⚠️
front/src/common/Map/Layers/GeoJSONs.tsx 0.00% 7 Missing ⚠️
front/src/common/Map/Layers/Signals.tsx 0.00% 4 Missing ⚠️
front/src/common/Map/Layers/OperationalPoints.tsx 0.00% 3 Missing ⚠️
front/src/applications/referenceMap/Map.tsx 0.00% 1 Missing ⚠️
...ront/src/common/Map/Layers/extensions/SNCF/PSL.tsx 0.00% 1 Missing ⚠️
...mulationResult/components/SimulationResultsMap.tsx 0.00% 1 Missing ⚠️
...ainschedule/components/ImportTrainSchedule/Map.tsx 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5876      +/-   ##
============================================
- Coverage     19.70%   19.70%   -0.01%     
  Complexity     2345     2345              
============================================
  Files           910      910              
  Lines        108075   108137      +62     
  Branches       2634     2634              
============================================
+ Hits          21299    21310      +11     
- Misses        85216    85267      +51     
  Partials       1560     1560              
Flag Coverage Δ
front 8.64% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix ! Lgtm and tested :) Left just one suggestion

front/src/common/Map/Layers/KPLabel.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM. Good job ! 💪

@clarani clarani force-pushed the cni-5797-console-error-psl branch from 1c53e3e to 09ff38e Compare November 28, 2023 14:22
@clarani clarani enabled auto-merge November 28, 2023 14:23
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@clarani clarani added this pull request to the merge queue Nov 28, 2023
Merged via the queue into dev with commit 9667656 Nov 28, 2023
7 checks passed
@clarani clarani deleted the cni-5797-console-error-psl branch November 28, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console error when adding a psl
5 participants