-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: rewrite kp label layer #5876
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5876 +/- ##
============================================
- Coverage 19.70% 19.70% -0.01%
Complexity 2345 2345
============================================
Files 910 910
Lines 108075 108137 +62
Branches 2634 2634
============================================
+ Hits 21299 21310 +11
- Misses 85216 85267 +51
Partials 1560 1560
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fix ! Lgtm and tested :) Left just one suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM. Good job ! 💪
1c53e3e
to
09ff38e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
closes #5797
The problem was that if a source is of type geojson, it can not receive a source-layer.
In this PR I: