editoast: infra/{id}/pathfinding starts in both directions #5904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5904 +/- ##
============================================
+ Coverage 25.74% 25.80% +0.06%
Complexity 2117 2117
============================================
Files 926 926
Lines 122479 122526 +47
Branches 2665 2665
============================================
+ Hits 31534 31620 +86
+ Misses 89372 89333 -39
Partials 1573 1573
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
multun
approved these changes
Nov 29, 2023
flomonster
requested changes
Nov 29, 2023
There was a problem hiding this comment.
We have a 400 error.
{
"status": 400,
"type": "editoast:JsonError",
"context": {
"cause": "Json deserialize error: unknown field `direction`, expected `track` or `position` at line 1 column 84"
},
"message": "Json deserialize error: unknown field `direction`, expected `track` or `position` at line 1 column 84"
}
bougue-pe
reviewed
Nov 30, 2023
SharglutDev
approved these changes
Dec 1, 2023
SharglutDev
requested changes
Dec 1, 2023
There was a problem hiding this comment.
Actually front looks good but got the same error as @flomonster when trying to search for routes
SharglutDev
approved these changes
Dec 1, 2023
flomonster
requested changes
Dec 1, 2023
…the initial direction
editoast computes k-shortest path. When we are along a simple line, the next shortest path can be significant longer than the initial solution. This commit limits any subsequent path to be at most twice as long as the best solution. From an implementation point of view, we need to track the total length at each step. This is a bit cumbersome, but we can’t access with the pathfinding crate to cost data.
Math-R
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5543