Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: make main script more homogeneous #5926

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented Nov 30, 2023

No description provided.

@Castavo Castavo requested a review from a team as a code owner November 30, 2023 11:05
@Castavo Castavo requested a review from hamz2a November 30, 2023 11:05
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5573ee0) 26.49% compared to head (2c5ab7d) 26.49%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5926      +/-   ##
============================================
- Coverage     26.49%   26.49%   -0.01%     
  Complexity     2117     2117              
============================================
  Files           930      930              
  Lines        122661   122661              
  Branches       2664     2664              
============================================
- Hits          32499    32498       -1     
- Misses        88590    88591       +1     
  Partials       1572     1572              
Flag Coverage Δ
core 79.01% <ø> (ø)
editoast 74.51% <ø> (-0.01%) ⬇️
front 9.31% <ø> (ø)
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Castavo Castavo requested a review from Tguisnet November 30, 2023 11:19
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could return CliError instead of println command-line errors.

@Castavo Castavo self-assigned this Nov 30, 2023
editoast/src/main.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Castavo Castavo force-pushed the bpt/editoast/tiny-main-tidy branch from 6e03613 to c870523 Compare December 1, 2023 09:43
Copy link
Contributor

@hamz2a hamz2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@Tguisnet Tguisnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Castavo Castavo enabled auto-merge December 5, 2023 08:37
@Castavo Castavo force-pushed the bpt/editoast/tiny-main-tidy branch from c870523 to 2c5ab7d Compare December 5, 2023 17:51
@Castavo Castavo added this pull request to the merge queue Dec 5, 2023
Merged via the queue into dev with commit e0b8640 Dec 5, 2023
17 checks passed
@Castavo Castavo deleted the bpt/editoast/tiny-main-tidy branch December 5, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants