Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove timeline, fix filter bug, fix signals pk #5992

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

nicolaswurtz
Copy link
Contributor

@nicolaswurtz nicolaswurtz commented Dec 4, 2023

@nicolaswurtz nicolaswurtz requested a review from a team as a code owner December 4, 2023 14:44
@nicolaswurtz nicolaswurtz added the area:front Work on Standard OSRD Interface modules label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (d943cdf) 26.49% compared to head (871c1c8) 26.48%.

Files Patch % Lines
...ons/operationalStudies/views/SimulationResults.tsx 0.00% 4 Missing ⚠️
front/src/main/home.jsx 0.00% 3 Missing ⚠️
front/src/applications/operationalStudies/Home.tsx 0.00% 2 Missing ⚠️
.../applications/operationalStudies/views/Project.tsx 0.00% 2 Missing ⚠️
...rc/applications/operationalStudies/views/Study.tsx 0.00% 2 Missing ⚠️
front/src/common/Map/Layers/KPLabel.ts 0.00% 1 Missing ⚠️
...ents/ManageTrainSchedule/Allowances/Allowances.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5992      +/-   ##
============================================
- Coverage     26.49%   26.48%   -0.01%     
  Complexity     2117     2117              
============================================
  Files           930      930              
  Lines        122674   122680       +6     
  Branches       2664     2664              
============================================
  Hits          32497    32497              
- Misses        88605    88611       +6     
  Partials       1572     1572              
Flag Coverage Δ
core 79.01% <ø> (ø)
editoast 74.51% <ø> (ø)
front 9.31% <0.00%> (-0.01%) ⬇️
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolaswurtz nicolaswurtz force-pushed the nwz/temporarily-remove-timeline branch 2 times, most recently from 9d1e80b to 0da8b43 Compare December 5, 2023 12:40
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Tested ✅

@nicolaswurtz nicolaswurtz force-pushed the nwz/temporarily-remove-timeline branch from 0da8b43 to 0c2a788 Compare December 6, 2023 05:34
@nicolaswurtz nicolaswurtz force-pushed the nwz/temporarily-remove-timeline branch from 0c2a788 to 871c1c8 Compare December 6, 2023 05:34
@nicolaswurtz nicolaswurtz added this pull request to the merge queue Dec 6, 2023
Merged via the queue into dev with commit 0f737d0 Dec 6, 2023
17 checks passed
@nicolaswurtz nicolaswurtz deleted the nwz/temporarily-remove-timeline branch December 6, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search in project does not work
3 participants