Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editoast layer cache invalidation #6004

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix editoast layer cache invalidation #6004

merged 1 commit into from
Dec 5, 2023

Conversation

flomonster
Copy link
Contributor

close #5931

@flomonster flomonster requested a review from a team as a code owner December 5, 2023 13:49
@flomonster flomonster changed the title editoast: fix layer cache invalidation Fix editoast layer cache invalidation Dec 5, 2023
@flomonster flomonster force-pushed the fam/fix-layer-invalidation branch from e28003a to afe2c44 Compare December 5, 2023 14:25
@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (e512a3c) 25.85% compared to head (40ec853) 25.79%.
Report is 9 commits behind head on dev.

Files Patch % Lines
editoast/src/map/mod.rs 33.33% 30 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6004      +/-   ##
============================================
- Coverage     25.85%   25.79%   -0.06%     
  Complexity     2117     2117              
============================================
  Files           926      928       +2     
  Lines        122581   122501      -80     
  Branches       2665     2667       +2     
============================================
- Hits          31694    31605      -89     
- Misses        89314    89321       +7     
- Partials       1573     1575       +2
Flag Coverage Δ
core 79.01% <ø> (ø)
editoast 74.37% <40.00%> (+0.11%) ⬆️
front 8.42% <ø> (-0.01%) ⬇️
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Erashin
Erashin approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

editoast/src/map/mod.rs Outdated Show resolved Hide resolved
woshilapin
woshilapin approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment, opinionated on some pattern. I'm good to merge as-is, without addressing it if you think it useless. Apart from that, not sure I understand everything 😅 but looks good!

editoast/src/map/mod.rs Outdated Show resolved Hide resolved
@flomonster flomonster force-pushed the fam/fix-layer-invalidation branch from d5ccf97 to cf63be3 Compare December 5, 2023 15:41
@flomonster flomonster enabled auto-merge December 5, 2023 16:13
leovalais
leovalais approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested

editoast/src/map/mod.rs Outdated Show resolved Hide resolved
@flomonster flomonster force-pushed the fam/fix-layer-invalidation branch from cf63be3 to 40ec853 Compare December 5, 2023 16:42
@flomonster flomonster added this pull request to the merge queue Dec 5, 2023
Merged via the queue into dev with commit 85c8f75 Dec 5, 2023
17 checks passed
@flomonster flomonster deleted the fam/fix-layer-invalidation branch December 5, 2023 17:06
@Tguisnet
Copy link
Contributor

Tguisnet commented Dec 5, 2023

A bit late but LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erashin Erashin Erashin approved these changes

@leovalais leovalais leovalais approved these changes

@woshilapin woshilapin woshilapin approved these changes

@Tguisnet Tguisnet Awaiting requested review from Tguisnet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layer invalidation does not work properly
5 participants
@flomonster @Tguisnet @woshilapin @leovalais @Erashin