Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add editoast openapi sync test #6069

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented Dec 7, 2023

We need a CI check to ensure that any modification of the endpoints or the schemas have been documented into openapi.yaml.

Debugged-by: Younes Khoudli [email protected] 🫡

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f4de8f) 26.56% compared to head (d9b5a69) 26.56%.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6069   +/-   ##
=========================================
  Coverage     26.56%   26.56%           
  Complexity     2122     2122           
=========================================
  Files           931      931           
  Lines        122965   122971    +6     
  Branches       2675     2675           
=========================================
+ Hits          32664    32670    +6     
  Misses        88716    88716           
  Partials       1585     1585           
Flag Coverage Δ
core 78.98% <ø> (ø)
editoast 74.66% <100.00%> (ø)
front 9.34% <100.00%> (+<0.01%) ⬆️
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais force-pushed the lva/editoast-openapi-ci-check branch 2 times, most recently from 8c9593a to f883cdb Compare December 7, 2023 15:48
@ElysaSrc ElysaSrc force-pushed the lva/editoast-openapi-ci-check branch from f883cdb to 3ac511e Compare December 11, 2023 10:40
@leovalais leovalais marked this pull request as ready for review December 11, 2023 10:59
@leovalais leovalais requested review from a team as code owners December 11, 2023 10:59
@leovalais leovalais force-pushed the lva/editoast-openapi-ci-check branch from 7eabeba to d9b5a69 Compare December 11, 2023 13:38
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leovalais leovalais added this pull request to the merge queue Dec 12, 2023
Merged via the queue into dev with commit 3afe9e4 Dec 12, 2023
18 checks passed
@leovalais leovalais deleted the lva/editoast-openapi-ci-check branch December 12, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants