Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix front warped map bug #6087

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Fix front warped map bug #6087

merged 1 commit into from
Dec 11, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 8, 2023

closes #5998

@clarani clarani requested a review from a team as a code owner December 8, 2023 16:00
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (381f900) 26.55% compared to head (d13bb3e) 26.54%.

Files Patch % Lines
front/src/common/Map/WarpedMap/core/projection.ts 0.00% 6 Missing ⚠️
...t/src/common/Map/WarpedMap/SimulationWarpedMap.tsx 0.00% 5 Missing ⚠️
front/src/common/Map/WarpedMap/getWarping.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6087      +/-   ##
============================================
- Coverage     26.55%   26.54%   -0.01%     
  Complexity     2118     2118              
============================================
  Files           931      931              
  Lines        122945   122951       +6     
  Branches       2673     2673              
============================================
- Hits          32644    32643       -1     
- Misses        88716    88723       +7     
  Partials       1585     1585              
Flag Coverage Δ
core 78.94% <ø> (ø)
editoast 74.66% <ø> (-0.01%) ⬇️
front 9.33% <0.00%> (-0.01%) ⬇️
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani enabled auto-merge December 8, 2023 17:00
@clarani clarani disabled auto-merge December 8, 2023 17:00
@flomonster flomonster changed the title front: fix warpedMap bug Fix front warped map bug Dec 11, 2023
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested (no more white screen), thanks for the hotfix

@clarani clarani added this pull request to the merge queue Dec 11, 2023
Merged via the queue into dev with commit 8e90aac Dec 11, 2023
17 checks passed
@clarani clarani deleted the cni-5998-fix-warped-map branch December 11, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WarpedMap NaN in camera bounds
3 participants