Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new editor error for node endpoints unicity #6172

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Add new editor error for node endpoints unicity #6172

merged 1 commit into from
Dec 22, 2023

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Dec 20, 2023 •
edited
Loading

close #6159

How to test it?

  • Create an empty infra
  • Create a new track section
  • Create a node (a switch) using multiple times the same track endpoint
  • An infra error should be visible

@flomonster flomonster requested a review from a team as a code owner December 20, 2023 11:15
@flomonster flomonster mentioned this pull request Dec 20, 2023
Closed
@flomonster flomonster marked this pull request as draft December 20, 2023 11:15
@flomonster flomonster force-pushed the fam/add-node-endpoints-not-unique branch 2 times, most recently from 6b5f103 to b9b4a12 Compare December 20, 2023 16:05
@flomonster flomonster mentioned this pull request Dec 20, 2023
Closed
14 tasks
@flomonster flomonster force-pushed the fam/add-node-endpoints-not-unique branch 3 times, most recently from cf3c5fe to 59eeee1 Compare December 21, 2023 13:58
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e731c96) 26.62% compared to head (7b8f5c6) 26.65%.
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6172      +/-   ##
============================================
+ Coverage     26.62%   26.65%   +0.02%     
  Complexity     2121     2121              
============================================
  Files           929      929              
  Lines        123373   123413      +40     
  Branches       2677     2677              
============================================
+ Hits          32851    32892      +41     
+ Misses        88929    88928       -1     
  Partials       1593     1593
Flag Coverage Δ
core 78.83% <ø> (ø)
editoast 74.98% <100.00%> (+0.04%) ⬆️
front 9.37% <100.00%> (+<0.01%) ⬆️
gateway 2.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster force-pushed the fam/add-node-endpoints-not-unique branch from 59eeee1 to 0cae004 Compare December 21, 2023 14:55
@flomonster flomonster marked this pull request as ready for review December 21, 2023 14:57
@flomonster flomonster requested a review from a team as a code owner December 21, 2023 14:57
@flomonster flomonster force-pushed the fam/add-node-endpoints-not-unique branch from 0cae004 to 7b8f5c6 Compare December 21, 2023 15:08
woshilapin
woshilapin requested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Wonderful, a new error 👏

editoast/src/generated_data/error/switches.rs Show resolved Hide resolved
editoast/src/schema/errors.rs Show resolved Hide resolved
front/public/locales/fr/translation.json Show resolved Hide resolved
woshilapin
woshilapin approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comment is minor. Apart from that, it's good for me.

Tguisnet
Tguisnet approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@Tguisnet Tguisnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Not mandatory, but you could add a test for a switch with 2 ports on a same track, but not the same endpoint, to ensure there is no error in this case.

clarani
clarani approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the frontend part, tested ✅

@flomonster flomonster added this pull request to the merge queue Dec 22, 2023
Merged via the queue into dev with commit 044204f Dec 22, 2023
18 checks passed
@flomonster flomonster deleted the fam/add-node-endpoints-not-unique branch December 22, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

@Tguisnet Tguisnet Tguisnet approved these changes

@woshilapin woshilapin woshilapin approved these changes

@Wadjetz Wadjetz Wadjetz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"The infrastructure contains errors" message while no error detected in infra editor
5 participants
@flomonster @Wadjetz @woshilapin @Tguisnet @clarani