Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add a class to concatenate envelope without deep copy #6179

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Dec 21, 2023

Fix #6177

  1. EnvelopeStopWrapper can use an abstract EnvelopeTimeInterpolate as input
  2. rename EnvelopeStopWrapper.iterateCurve to iteratePoints and move it to the interface EnvelopeTimeInterpolate
  3. add EnvelopeConcat, implementing EnvelopeTimeInterpolate using a list of envelopes

@eckter eckter requested a review from a team as a code owner December 21, 2023 11:08
@eckter eckter requested a review from Erashin December 21, 2023 11:08
@eckter eckter force-pushed the ech/add-envelope-concatenation branch from aae46cf to 2277577 Compare December 21, 2023 11:10
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (ea45fc5) 26.62% compared to head (181b557) 26.65%.

Files Patch % Lines
...ain/java/fr/sncf/osrd/envelope/EnvelopeConcat.java 86.53% 2 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6179      +/-   ##
============================================
+ Coverage     26.62%   26.65%   +0.02%     
- Complexity     2121     2139      +18     
============================================
  Files           929      931       +2     
  Lines        123373   123429      +56     
  Branches       2677     2682       +5     
============================================
+ Hits          32852    32900      +48     
- Misses        88928    88931       +3     
- Partials       1593     1598       +5     
Flag Coverage Δ
core 78.87% <91.02%> (+0.04%) ⬆️
editoast 74.94% <ø> (-0.01%) ⬇️
front 9.36% <ø> (ø)
gateway 2.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/add-envelope-concatenation branch from 2277577 to 61b9c6a Compare December 21, 2023 14:25
@eckter eckter force-pushed the ech/add-envelope-concatenation branch from 61b9c6a to 181b557 Compare December 21, 2023 15:09
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eckter eckter added this pull request to the merge queue Dec 22, 2023
Merged via the queue into dev with commit ee0649e Dec 22, 2023
18 checks passed
@eckter eckter deleted the ech/add-envelope-concatenation branch December 22, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: write a class to concatenate envelopes without copy
2 participants