Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: adapt import timetable to add fake_stops #6238

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

younesschrifi
Copy link
Contributor

No description provided.

@younesschrifi younesschrifi requested a review from a team as a code owner December 31, 2023 22:30
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (6c12f67) 26.90% compared to head (ea708bd) 26.91%.
Report is 1 commits behind head on dev.

Files Patch % Lines
editoast/src/views/timetable.rs 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6238   +/-   ##
=========================================
  Coverage     26.90%   26.91%           
  Complexity     2139     2139           
=========================================
  Files           932      932           
  Lines        123970   124028   +58     
  Branches       2689     2689           
=========================================
+ Hits          33352    33377   +25     
- Misses        89013    89046   +33     
  Partials       1605     1605           
Flag Coverage Δ
core 78.87% <ø> (ø)
editoast 75.29% <0.00%> (-0.06%) ⬇️
front 9.47% <ø> (ø)
gateway 2.54% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Not tested)

@younesschrifi younesschrifi added this pull request to the merge queue Jan 8, 2024
Merged via the queue into dev with commit df233d6 Jan 8, 2024
18 checks passed
@younesschrifi younesschrifi deleted the yci/fix-wrong-train-description branch January 8, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants