Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: gitignore private test data #6357

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Jan 16, 2024

No description provided.

@Khoyo Khoyo added the area:integration-tests Work on Integration test, by nature related to different services label Jan 16, 2024
@Khoyo Khoyo self-assigned this Jan 16, 2024
@Khoyo Khoyo requested a review from a team as a code owner January 16, 2024 08:50
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b997a5f) 27.91% compared to head (d531593) 27.91%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6357      +/-   ##
============================================
- Coverage     27.91%   27.91%   -0.01%     
  Complexity     2162     2162              
============================================
  Files          1000     1000              
  Lines        126356   126356              
  Branches       2578     2578              
============================================
- Hits          35272    35269       -3     
- Misses        89595    89598       +3     
  Partials       1489     1489              
Flag Coverage Δ
core 78.66% <ø> (ø)
editoast 75.80% <ø> (-0.02%) ⬇️
front 8.70% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.42% <ø> (ø)
tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Khoyo Khoyo added this pull request to the merge queue Jan 16, 2024
Merged via the queue into dev with commit 66b4f2b Jan 16, 2024
20 checks passed
@Khoyo Khoyo deleted the yk/gitignore-private-test-data branch January 16, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:integration-tests Work on Integration test, by nature related to different services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants