front: fix scenario timetable height #8015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flomonster
force-pushed
the
cni-fix-scenario-height
branch
from
c80c0d6 to
ea89983
Compare
|
This is a revert of: #7993 |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8015 +/- ##
============================================
- Coverage 28.07% 28.07% -0.01%
Complexity 2075 2075
============================================
Files 1288 1288
Lines 157708 157712 +4
Branches 3121 3121
============================================
- Hits 44280 44276 -4
- Misses 111551 111559 +8
Partials 1877 1877
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
flomonster
approved these changes
Jul 11, 2024
|
Ah, RIP. Sorry 'bout that. |
1 task
emersion
added a commit
that referenced
this pull request
Aug 21, 2024
This is a re-do of #7993, which got reverted in #8015 because of a bug when the timetable contains lots of trains. In a flex context, the implicit default value for min-height is auto, and that prevents elements from overflowing with a scrollbar (because min-height wins against height and max-height). Override the default with "min-height: 0".
emersion
added a commit
that referenced
this pull request
Aug 29, 2024
This is a re-do of #7993, which got reverted in #8015 because of a bug when the timetable contains lots of trains. In a flex context, the implicit default value for min-height is auto, and that prevents elements from overflowing with a scrollbar (because min-height wins against height and max-height). Override the default with "min-height: 0".
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
This is a re-do of #7993, which got reverted in #8015 because of a bug when the timetable contains lots of trains. In a flex context, the implicit default value for min-height is auto, and that prevents elements from overflowing with a scrollbar (because min-height wins against height and max-height). Override the default with "min-height: 0".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8012