Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: add override for Docker socket path #8480

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

emersion
Copy link
Member

Some systems (e.g. podman) have a non-standard socket path. Allow developers to override the default via a .env file.

I've tried using compose.override.yml but it doesn't seem to work.

Some systems (e.g. podman) have a non-standard socket path. Allow
developers to override the default via a .env file.

I've tried using compose.override.yml but it doesn't seem to work.
@emersion emersion requested a review from a team as a code owner August 19, 2024 09:26
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.99%. Comparing base (7b80536) to head (24d6caf).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8480      +/-   ##
============================================
- Coverage     36.99%   36.99%   -0.01%     
  Complexity     2168     2168              
============================================
  Files          1271     1271              
  Lines        117955   117955              
  Branches       3171     3171              
============================================
- Hits          43642    43634       -8     
- Misses        72440    72448       +8     
  Partials       1873     1873              
Flag Coverage Δ
core 74.96% <ø> (ø)
editoast 66.38% <ø> (-0.03%) ⬇️
front 15.95% <ø> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@emersion emersion added this pull request to the merge queue Aug 29, 2024
Merged via the queue into dev with commit fe6fb65 Aug 29, 2024
22 checks passed
@emersion emersion deleted the emr/docker-socket branch August 29, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants