editoast: harmonize comfort type #8525

younesschrifi · 2024-08-21T21:01:09Z

codecov-commenter · 2024-08-21T21:06:19Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 36.82%. Comparing base (931e582) to head (1d1fac4).
Report is 54 commits behind head on dev.

Files with missing lines	Patch %	Lines
...ules/rollingStock/components/RollingStockCurve.tsx	12.50%	7 Missing ⚠️
...ponents/RollingStockEditor/CurveParamSelectors.tsx	37.50%	5 Missing ⚠️
...k/components/RollingStockCard/RollingStockCard.tsx	0.00%	2 Missing ⚠️
...nents/RollingStockCard/RollingStockCardButtons.tsx	0.00%	2 Missing ⚠️
...ts/RollingStockEditor/RollingStockEditorCurves.tsx	33.33%	2 Missing ⚠️
...ollingStockEditor/RollingStockInformationPanel.tsx	0.00%	2 Missing ⚠️
front/src/stories/RollingStockSelector.stories.tsx	0.00%	2 Missing ⚠️
...onents/RollingStockCard/RollingStockCardDetail.tsx	75.00%	1 Missing ⚠️
front/src/modules/rollingStock/helpers/curves.ts	50.00%	1 Missing ⚠️
...modules/rollingStock/helpers/rollingStockEditor.ts	50.00%	1 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #8525      +/-   ##
============================================
- Coverage     36.85%   36.82%   -0.03%     
- Complexity     2177     2213      +36     
============================================
  Files          1254     1255       +1     
  Lines        113631   113801     +170     
  Branches       3202     3185      -17     
============================================
+ Hits          41881    41912      +31     
- Misses        69856    69997     +141     
+ Partials       1894     1892       -2

Flag	Coverage Δ
core	`74.75% <100.00%> (-0.05%)`	⬇️
editoast	`71.72% <ø> (-0.04%)`	⬇️
front	`14.92% <40.90%> (-0.04%)`	⬇️
gateway	`2.20% <ø> (ø)`
osrdyne	`2.71% <ø> (ø)`
railjson_generator	`87.49% <ø> (ø)`
tests	`86.45% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SharglutDev

Thank you for this PR ! Left comments, we need to test carefully to see if we missed something.

front/src/common/api/generatedEditoastApi.ts

front/src/modules/rollingStock/components/RollingStockCard/RollingStockCard.tsx

front/src/modules/rollingStock/components/RollingStockCurve.tsx

front/src/common/api/generatedEditoastApi.ts

shenriotpro

LGTM for tests/

woshilapin

Nice clean up and homogenization. Thank you.

core/osrd-railjson/src/main/java/fr/sncf/osrd/railjson/schema/rollingstock/RJSComfortType.java

flomonster

LGTM

Erashin

GJ :)

editoast/migrations/2024-09-02-132335_replace_mode_ac_with_air_conditioning/up.sql

SharglutDev

Lgtm and tested, thank you for this PR !

younesschrifi force-pushed the yci/delete-tsv1-endpoint branch from 05ea353 to e6b2b6a Compare August 21, 2024 21:07

younesschrifi force-pushed the yci/harmonize_comfort_type branch from 61fba6d to 9862b0d Compare August 21, 2024 21:08

younesschrifi force-pushed the yci/delete-tsv1-endpoint branch 2 times, most recently from 7c70671 to 808e450 Compare August 21, 2024 21:21

younesschrifi force-pushed the yci/harmonize_comfort_type branch from 9862b0d to 2d9ca2b Compare August 21, 2024 21:25

younesschrifi force-pushed the yci/delete-tsv1-endpoint branch 2 times, most recently from 20adb70 to 873f7e1 Compare August 22, 2024 22:35

younesschrifi force-pushed the yci/harmonize_comfort_type branch from 2d9ca2b to 8dfa78d Compare August 22, 2024 22:38

younesschrifi force-pushed the yci/delete-tsv1-endpoint branch 2 times, most recently from 0f89754 to 761ed1d Compare August 29, 2024 13:03

younesschrifi force-pushed the yci/harmonize_comfort_type branch from 8dfa78d to 5055a60 Compare August 29, 2024 13:18

younesschrifi force-pushed the yci/delete-tsv1-endpoint branch 4 times, most recently from dc55996 to f7b9ae4 Compare August 29, 2024 14:53

Base automatically changed from yci/delete-tsv1-endpoint to dev August 29, 2024 15:40

younesschrifi force-pushed the yci/harmonize_comfort_type branch from e4bc969 to 8f93c46 Compare August 29, 2024 15:42

younesschrifi marked this pull request as ready for review August 29, 2024 15:44

younesschrifi requested review from a team as code owners August 29, 2024 15:44

SharglutDev requested changes Aug 29, 2024

View reviewed changes

younesschrifi requested a review from a team as a code owner August 30, 2024 08:22

younesschrifi requested a review from shenriotpro August 30, 2024 08:22

younesschrifi requested a review from a team as a code owner August 30, 2024 08:24

younesschrifi requested a review from eckter August 30, 2024 08:24

shenriotpro approved these changes Aug 30, 2024

View reviewed changes

younesschrifi added 2 commits August 30, 2024 11:13

editoast: harmonize comfort type

44c161a

front: harmonize comfort type

8647b8d

younesschrifi force-pushed the yci/harmonize_comfort_type branch from ee70491 to f603f28 Compare August 30, 2024 09:13

woshilapin approved these changes Aug 30, 2024

View reviewed changes

Erashin requested changes Aug 30, 2024

View reviewed changes

core/osrd-railjson/src/main/java/fr/sncf/osrd/railjson/schema/rollingstock/RJSComfortType.java Outdated Show resolved Hide resolved

flomonster approved these changes Aug 30, 2024

View reviewed changes

younesschrifi force-pushed the yci/harmonize_comfort_type branch from f603f28 to 1cc82a9 Compare September 2, 2024 07:52

tests: harmonize comfort type

607a9a9

younesschrifi force-pushed the yci/harmonize_comfort_type branch from 1cc82a9 to 2b1c2a4 Compare September 2, 2024 07:53

younesschrifi self-assigned this Sep 2, 2024

younesschrifi force-pushed the yci/harmonize_comfort_type branch from e6de396 to a2dbf38 Compare September 2, 2024 09:34

core: harmonize comfort type

73f64a9

Erashin force-pushed the yci/harmonize_comfort_type branch from a2dbf38 to 73f64a9 Compare September 2, 2024 12:26

Erashin approved these changes Sep 2, 2024

View reviewed changes

flomonster reviewed Sep 2, 2024

View reviewed changes

editoast/migrations/2024-09-02-132335_replace_mode_ac_with_air_conditioning/up.sql Show resolved Hide resolved

younesschrifi force-pushed the yci/harmonize_comfort_type branch 2 times, most recently from 5279a26 to ebd3b0d Compare September 3, 2024 07:38

flomonster reviewed Sep 3, 2024

View reviewed changes

editoast/migrations/2024-09-02-132335_replace_mode_ac_with_air_conditioning/up.sql Outdated Show resolved Hide resolved

editoast: add new migration

1d1fac4

younesschrifi force-pushed the yci/harmonize_comfort_type branch from ebd3b0d to 1d1fac4 Compare September 3, 2024 07:41

SharglutDev approved these changes Sep 3, 2024

View reviewed changes

younesschrifi added this pull request to the merge queue Sep 3, 2024

Merged via the queue into dev with commit 53bd1e9 Sep 3, 2024
22 checks passed

younesschrifi deleted the yci/harmonize_comfort_type branch September 3, 2024 11:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

editoast: harmonize comfort type #8525

editoast: harmonize comfort type #8525

younesschrifi commented Aug 21, 2024 •

edited

Loading

codecov-commenter commented Aug 21, 2024 •

edited

Loading

SharglutDev left a comment

shenriotpro left a comment

woshilapin left a comment

flomonster left a comment

Erashin left a comment

SharglutDev left a comment

editoast: harmonize comfort type #8525

editoast: harmonize comfort type #8525

Conversation

younesschrifi commented Aug 21, 2024 • edited Loading

codecov-commenter commented Aug 21, 2024 • edited Loading

Codecov Report

SharglutDev left a comment

Choose a reason for hiding this comment

shenriotpro left a comment

Choose a reason for hiding this comment

woshilapin left a comment

Choose a reason for hiding this comment

flomonster left a comment

Choose a reason for hiding this comment

Erashin left a comment

Choose a reason for hiding this comment

SharglutDev left a comment

Choose a reason for hiding this comment

younesschrifi commented Aug 21, 2024 •

edited

Loading

codecov-commenter commented Aug 21, 2024 •

edited

Loading