editoast: remove unused features in dependencies #8603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing unused features did remove a bunch of transitive dependencies. When trying `cargo check --workspace`, 615 dependencies were used before, now, 570 dependencies are used.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8603 +/- ##
============================================
- Coverage 36.84% 36.84% -0.01%
Complexity 2175 2175
============================================
Files 1279 1279
Lines 118794 118767 -27
Branches 3188 3188
============================================
- Hits 43774 43757 -17
+ Misses 73135 73125 -10
Partials 1885 1885
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
woshilapin
force-pushed
the
wsl/editoast/build/shave-features
branch
from
9c733f1 to
5c380c7
Compare
leovalais
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unused features did remove a bunch of transitive dependencies.
When trying
cargo check --workspace, 615 dependencies were used before, now, 570 dependencies are used.