Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: turn on noUnusedLocals #8696

Merged
merged 3 commits into from
Sep 5, 2024
Merged

front: turn on noUnusedLocals #8696

merged 3 commits into from
Sep 5, 2024

Conversation

emersion
Copy link
Member

@emersion emersion commented Sep 2, 2024

This warns when something is imported but isn't actually used.

See individual commits.

@emersion emersion requested a review from a team as a code owner September 2, 2024 13:56
@emersion emersion marked this pull request as draft September 2, 2024 13:56
@emersion emersion self-assigned this Sep 2, 2024
Forcing all .tsx/.jsx files to include React is cargo culting from
old versions of the JSX compiler which were merely performing
string substitution. Since React version 17 this isn't required
anymore and the unused React imports can be dropped.
This warns when something is imported but isn't actually used.
@emersion emersion force-pushed the emr/no-unused-locals branch from 76bf800 to 899ee6d Compare September 5, 2024 11:56
@emersion emersion marked this pull request as ready for review September 5, 2024 11:56
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@emersion emersion added this pull request to the merge queue Sep 5, 2024
Merged via the queue into dev with commit 144cf22 Sep 5, 2024
22 checks passed
@emersion emersion deleted the emr/no-unused-locals branch September 5, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants