Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add cli to manage stdcm search environments #8745

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented Sep 4, 2024

close #8272

Add 3 commands:

  • show
  • set-from-scratch
  • set-from-scenario

I don't know if set-from-scratch will ever be useful...

I also chose to make the search window 1 day bigger than the start of the last train, in order to be able to ask for an STDCM arrival time which arrives later than the departure of the last train in the timetable. I don't know if that makes a lot of sense, what do you think ?

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 80.11050% with 36 lines in your changes missing coverage. Please review.

Project coverage is 37.07%. Comparing base (d420d30) to head (42fefa4).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/client/stdcm_search_env_commands.rs 77.07% 36 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8745      +/-   ##
============================================
+ Coverage     37.01%   37.07%   +0.05%     
  Complexity     2212     2212              
============================================
  Files          1254     1255       +1     
  Lines        113938   114113     +175     
  Branches       3189     3189              
============================================
+ Hits          42177    42302     +125     
- Misses        69864    69914      +50     
  Partials       1897     1897              
Flag Coverage Δ
core 74.79% <ø> (ø)
editoast 72.41% <80.11%> (-0.01%) ⬇️
front 14.93% <ø> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Castavo Castavo force-pushed the bpt/editoast/cli-stdcm-search-env branch from 71c4d81 to 230306e Compare September 4, 2024 14:10
@Castavo Castavo marked this pull request as ready for review September 4, 2024 16:24
@Castavo Castavo requested a review from a team as a code owner September 4, 2024 16:24
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be much better with this utility. Thank you. Only minor comments, nothing is a blocker.

editoast/src/client/stdcm_search_env_commands.rs Outdated Show resolved Hide resolved
@Castavo Castavo force-pushed the bpt/editoast/cli-stdcm-search-env branch 2 times, most recently from f2eee1b to c3f4d26 Compare September 5, 2024 14:09
@Castavo Castavo requested a review from emersion September 6, 2024 13:01
@Castavo Castavo force-pushed the bpt/editoast/cli-stdcm-search-env branch from 67d3c89 to 3d5757d Compare September 6, 2024 13:17
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Add 3 commands:
* show
* set-from-scratch
* set-from-scenario
@Castavo Castavo force-pushed the bpt/editoast/cli-stdcm-search-env branch from 3d5757d to 42fefa4 Compare September 10, 2024 15:28
@Castavo Castavo enabled auto-merge September 10, 2024 15:42
@Castavo Castavo added this pull request to the merge queue Sep 10, 2024
Merged via the queue into dev with commit 5ce633a Sep 10, 2024
23 checks passed
@Castavo Castavo deleted the bpt/editoast/cli-stdcm-search-env branch September 10, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast: add cli and script for stdcm search env
4 participants