-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: add cli to manage stdcm search environments #8745
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8745 +/- ##
============================================
+ Coverage 37.01% 37.07% +0.05%
Complexity 2212 2212
============================================
Files 1254 1255 +1
Lines 113938 114113 +175
Branches 3189 3189
============================================
+ Hits 42177 42302 +125
- Misses 69864 69914 +50
Partials 1897 1897
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
71c4d81
to
230306e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be much better with this utility. Thank you. Only minor comments, nothing is a blocker.
f2eee1b
to
c3f4d26
Compare
67d3c89
to
3d5757d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Add 3 commands: * show * set-from-scratch * set-from-scenario
3d5757d
to
42fefa4
Compare
close #8272
Add 3 commands:
I don't know if set-from-scratch will ever be useful...
I also chose to make the search window 1 day bigger than the start of the last train, in order to be able to ask for an STDCM arrival time which arrives later than the departure of the last train in the timetable. I don't know if that makes a lot of sense, what do you think ?