Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: simplify stdcm edge builder #8766

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Sep 5, 2024

Turns out, starting the path with a node instead of an edge can make things much easier than before

Turns out, starting the path with a node
instead of an edge can make things much
easier than before
@eckter eckter requested a review from Erashin September 5, 2024 09:08
@eckter eckter requested a review from a team as a code owner September 5, 2024 09:08
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.90%. Comparing base (1b14ae3) to head (09cabc2).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8766      +/-   ##
============================================
- Coverage     36.92%   36.90%   -0.02%     
+ Complexity     2213     2208       -5     
============================================
  Files          1255     1255              
  Lines        114134   114110      -24     
  Branches       3188     3188              
============================================
- Hits          42142    42111      -31     
- Misses        70097    70104       +7     
  Partials       1895     1895              
Flag Coverage Δ
core 74.73% <100.00%> (-0.03%) ⬇️
editoast 72.05% <ø> (-0.04%) ⬇️
front 14.92% <ø> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaayyyy

@eckter eckter added this pull request to the merge queue Sep 5, 2024
Merged via the queue into dev with commit c2b8718 Sep 5, 2024
22 checks passed
@eckter eckter deleted the ech/simplify-edge-builder branch September 5, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants