Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: osm_to_railjson: add a readme example for Germany #8825

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

bougue-pe
Copy link
Contributor

Move back example doc close to the component

@bougue-pe bougue-pe requested a review from a team as a code owner September 11, 2024 09:00
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.04%. Comparing base (060fc5e) to head (3527e1f).
Report is 8 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8825      +/-   ##
============================================
- Coverage     37.05%   37.04%   -0.01%     
  Complexity     2209     2209              
============================================
  Files          1255     1255              
  Lines        114134   114134              
  Branches       3182     3182              
============================================
- Hits          42293    42283      -10     
- Misses        69949    69959      +10     
  Partials       1892     1892              
Flag Coverage Δ
core 74.79% <ø> (ø)
editoast 72.42% <ø> (-0.04%) ⬇️
front 14.92% <ø> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bougue-pe bougue-pe added the kind:documentation Work dedicated to explaining concepts, arch and intentions: Code is supposed to be documented inline label Sep 11, 2024
Copy link
Contributor

@Castavo Castavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra doc 😁

editoast/osm_to_railjson/README.md Outdated Show resolved Hide resolved
editoast/osm_to_railjson/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Baptiste comments

editoast/osm_to_railjson/README.md Outdated Show resolved Hide resolved
@bougue-pe bougue-pe changed the title editoast, osm_to_railjson: add a readme example for Germany editoast: osm_to_railjson: add a readme example for Germany Sep 11, 2024
editoast/osm_to_railjson/README.md Outdated Show resolved Hide resolved
editoast/osm_to_railjson/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for documenting the process.

editoast/osm_to_railjson/README.md Outdated Show resolved Hide resolved
editoast/osm_to_railjson/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Castavo Castavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10 would review again

@bougue-pe bougue-pe force-pushed the peb/doc/osm2rjs_germany branch from d7b9271 to 3527e1f Compare September 12, 2024 07:16
@bougue-pe bougue-pe added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 12, 2024
@bougue-pe bougue-pe added this pull request to the merge queue Sep 12, 2024
Merged via the queue into dev with commit c62c9db Sep 12, 2024
23 checks passed
@bougue-pe bougue-pe deleted the peb/doc/osm2rjs_germany branch September 12, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation Work dedicated to explaining concepts, arch and intentions: Code is supposed to be documented inline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants