Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove legacy v1 test data #8895

Merged
merged 1 commit into from
Sep 17, 2024
Merged

tests: remove legacy v1 test data #8895

merged 1 commit into from
Sep 17, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Sep 17, 2024

The files were still there but not used in the test suite. I've also removed the legacy field from the remaining jsons, and the filter in the test file collection.

The files were still there but not used in
the test suite. I've also removed the
legacy field from the remaining jsons.
@eckter eckter requested a review from a team as a code owner September 17, 2024 12:34
@eckter eckter requested a review from shenriotpro September 17, 2024 12:34
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.95%. Comparing base (512fe9a) to head (e772ef4).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8895      +/-   ##
============================================
- Coverage     36.96%   36.95%   -0.02%     
  Complexity     2211     2211              
============================================
  Files          1256     1256              
  Lines        114423   114423              
  Branches       3182     3182              
============================================
- Hits          42298    42286      -12     
- Misses        70234    70246      +12     
  Partials       1891     1891              
Flag Coverage Δ
core 74.84% <ø> (ø)
editoast 72.42% <ø> (-0.05%) ⬇️
front 14.90% <ø> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.60% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@eckter eckter added this pull request to the merge queue Sep 17, 2024
Merged via the queue into dev with commit 17c2755 Sep 17, 2024
23 checks passed
@eckter eckter deleted the ech/remove-legacy-test-data branch September 17, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants