-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: return list of missing locations in pathfinding #9113
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9113 +/- ##
============================================
- Coverage 37.17% 37.16% -0.01%
- Complexity 2240 2242 +2
============================================
Files 1260 1262 +2
Lines 115463 115857 +394
Branches 3267 3278 +11
============================================
+ Hits 42921 43058 +137
- Misses 70596 70845 +249
- Partials 1946 1954 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
999d2ec
to
348f4e1
Compare
348f4e1
to
17bba8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm for front part, not tested (we don't display these errors for now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! (Not tested.)
Signed-off-by: hamz2a <[email protected]>
17bba8f
to
2d2ff61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
closes #8636