Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: return list of missing locations in pathfinding #9113

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Sep 30, 2024

closes #8636

@hamz2a hamz2a requested a review from a team as a code owner September 30, 2024 13:23
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 37.16%. Comparing base (d97f288) to head (2d2ff61).
Report is 50 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/views/path/path_item_cache.rs 60.00% 6 Missing ⚠️
editoast/src/views/timetable/stdcm.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9113      +/-   ##
============================================
- Coverage     37.17%   37.16%   -0.01%     
- Complexity     2240     2242       +2     
============================================
  Files          1260     1262       +2     
  Lines        115463   115857     +394     
  Branches       3267     3278      +11     
============================================
+ Hits          42921    43058     +137     
- Misses        70596    70845     +249     
- Partials       1946     1954       +8     
Flag Coverage Δ
core 74.80% <ø> (+<0.01%) ⬆️
editoast 72.54% <76.66%> (+0.16%) ⬆️
front 15.19% <100.00%> (+0.01%) ⬆️
gateway 2.22% <ø> (+<0.01%) ⬆️
osrdyne 2.57% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a marked this pull request as draft September 30, 2024 13:43
@hamz2a hamz2a force-pushed the hai/editoast-identify-unrecognized-localtion-v2 branch 2 times, most recently from 999d2ec to 348f4e1 Compare September 30, 2024 15:05
@hamz2a hamz2a marked this pull request as ready for review September 30, 2024 15:20
@hamz2a hamz2a requested a review from a team as a code owner September 30, 2024 15:20
@hamz2a hamz2a force-pushed the hai/editoast-identify-unrecognized-localtion-v2 branch from 348f4e1 to 17bba8f Compare September 30, 2024 15:44
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm for front part, not tested (we don't display these errors for now)

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! (Not tested.)

editoast/src/views/path/pathfinding.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-identify-unrecognized-localtion-v2 branch from 17bba8f to 2d2ff61 Compare October 1, 2024 13:38
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hamz2a hamz2a added this pull request to the merge queue Oct 1, 2024
Merged via the queue into dev with commit c8d96e7 Oct 1, 2024
23 checks passed
@hamz2a hamz2a deleted the hai/editoast-identify-unrecognized-localtion-v2 branch October 1, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editoast: being able to identify unrecognized PR in the infrastructure
6 participants