Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: redesing conflicts list #9280

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

theocrsb
Copy link
Contributor

closes this issue

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 39.15%. Comparing base (e66e534) to head (ffeaf6e).
Report is 58 commits behind head on dev.

Files with missing lines Patch % Lines
...t/src/modules/conflict/components/ConflictCard.tsx 0.00% 15 Missing and 1 partial ⚠️
...s/trainschedule/components/Timetable/Timetable.tsx 0.00% 7 Missing ⚠️
.../src/modules/conflict/components/ConflictsList.tsx 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9280      +/-   ##
============================================
- Coverage     39.16%   39.15%   -0.02%     
  Complexity     2245     2245              
============================================
  Files          1290     1290              
  Lines         97265    97267       +2     
  Branches       3280     3280              
============================================
- Hits          38097    38081      -16     
- Misses        57229    57247      +18     
  Partials       1939     1939              
Flag Coverage Δ
core 74.94% <ø> (ø)
editoast 72.43% <ø> (-0.06%) ⬇️
front 10.33% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
osrdyne 3.52% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theocrsb theocrsb force-pushed the tce/front/trainschedule/redesign-conflicts branch 8 times, most recently from a965556 to 899d0f0 Compare October 14, 2024 06:17
@theocrsb theocrsb force-pushed the tce/front/trainschedule/redesign-conflicts branch from 899d0f0 to ffeaf6e Compare October 14, 2024 06:41
@theocrsb theocrsb marked this pull request as ready for review October 14, 2024 06:42
@theocrsb theocrsb requested a review from a team as a code owner October 14, 2024 06:42
Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@theocrsb theocrsb added this pull request to the merge queue Oct 21, 2024
Merged via the queue into dev with commit 600370b Oct 21, 2024
24 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedule/redesign-conflicts branch October 21, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants