Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add healthcheck command #9310

Merged
merged 1 commit into from
Oct 11, 2024
Merged

editoast: add healthcheck command #9310

merged 1 commit into from
Oct 11, 2024

Conversation

ElysaSrc
Copy link
Member

No description provided.

@ElysaSrc ElysaSrc requested a review from woshilapin October 11, 2024 10:23
@ElysaSrc ElysaSrc requested a review from a team as a code owner October 11, 2024 10:23
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick, thank you.

@ElysaSrc ElysaSrc enabled auto-merge October 11, 2024 10:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.99%. Comparing base (5c58af7) to head (3bf1a4b).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9310      +/-   ##
============================================
+ Coverage     38.55%   38.99%   +0.44%     
  Complexity     2244     2244              
============================================
  Files          1288     1289       +1     
  Lines         98454    97295    -1159     
  Branches       3273     3277       +4     
============================================
- Hits          37956    37939      -17     
+ Misses        58561    57419    -1142     
  Partials       1937     1937              
Flag Coverage Δ
core 74.83% <ø> (-0.05%) ⬇️
editoast 72.38% <100.00%> (-0.07%) ⬇️
front 10.13% <ø> (ø)
gateway 2.19% <ø> (ø)
osrdyne 3.52% <ø> (+1.08%) ⬆️
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

editoast/src/main.rs Outdated Show resolved Hide resolved
@ElysaSrc ElysaSrc force-pushed the ev/change-healthcheck branch from 0fafff1 to 3bf1a4b Compare October 11, 2024 10:46
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't in your discussion about the issue, sorry if you already answered this question, why keeping the endpoint? Can't we just change the docker compose health check to use the CLI?

@ElysaSrc
Copy link
Member Author

I wasn't in your discussion about the issue, sorry if you already answered this question, why keeping the endpoint? Can't we just change the docker compose health check to use the CLI?

Because we it's relevant for the readiness check and for the tileserver. All in all, it is a more accurate check going through the http server than spawning a process beside in the container..

@ElysaSrc ElysaSrc added this pull request to the merge queue Oct 11, 2024
Merged via the queue into dev with commit 9072683 Oct 11, 2024
24 checks passed
@ElysaSrc ElysaSrc deleted the ev/change-healthcheck branch October 11, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants