-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: add healthcheck command #9310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick, thank you.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9310 +/- ##
============================================
+ Coverage 38.55% 38.99% +0.44%
Complexity 2244 2244
============================================
Files 1288 1289 +1
Lines 98454 97295 -1159
Branches 3273 3277 +4
============================================
- Hits 37956 37939 -17
+ Misses 58561 57419 -1142
Partials 1937 1937
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: ElysaSrc <[email protected]>
0fafff1
to
3bf1a4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't in your discussion about the issue, sorry if you already answered this question, why keeping the endpoint? Can't we just change the docker compose health check to use the CLI?
Because we it's relevant for the readiness check and for the tileserver. All in all, it is a more accurate check going through the http server than spawning a process beside in the container.. |
No description provided.