Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: hard code composition codes #9329

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Oct 14, 2024

closes #9311
closes #8729

@theocrsb theocrsb requested a review from a team as a code owner October 14, 2024 09:27
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 39.12%. Comparing base (1f3cac3) to head (03b3279).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/applications/stdcm/consts.ts 0.00% 19 Missing ⚠️
...Selector/useStoreDataForSpeedLimitByTagSelector.ts 0.00% 9 Missing ⚠️
front/src/applications/stdcm/hooks/useStdcm.ts 0.00% 1 Missing ⚠️
...c/applications/stdcmV2/components/StdcmConsist.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9329      +/-   ##
============================================
- Coverage     39.16%   39.12%   -0.04%     
  Complexity     2245     2245              
============================================
  Files          1290     1290              
  Lines         97293    97317      +24     
  Branches       3280     3280              
============================================
- Hits          38100    38079      -21     
- Misses        57254    57299      +45     
  Partials       1939     1939              
Flag Coverage Δ
core 74.94% <ø> (ø)
editoast 72.40% <ø> (-0.08%) ⬇️
front 10.33% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
osrdyne 3.52% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job !

@theocrsb theocrsb force-pushed the tce/front/stdcm/add-composition-codes branch from d6c7f46 to 6f51c31 Compare October 14, 2024 15:10
@theocrsb theocrsb enabled auto-merge October 14, 2024 15:10
@theocrsb theocrsb force-pushed the tce/front/stdcm/add-composition-codes branch from 6f51c31 to 2d8b3af Compare October 15, 2024 11:59
@theocrsb theocrsb force-pushed the tce/front/stdcm/add-composition-codes branch from 2d8b3af to 695d55a Compare October 15, 2024 12:20
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the back-and-forth, LGTM :)

@theocrsb theocrsb force-pushed the tce/front/stdcm/add-composition-codes branch from 0379293 to 03b3279 Compare October 15, 2024 14:27
@theocrsb theocrsb added this pull request to the merge queue Oct 15, 2024
Merged via the queue into dev with commit d768e04 Oct 15, 2024
24 checks passed
@theocrsb theocrsb deleted the tce/front/stdcm/add-composition-codes branch October 15, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants