-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: hard code composition codes #9329
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9329 +/- ##
============================================
- Coverage 39.16% 39.12% -0.04%
Complexity 2245 2245
============================================
Files 1290 1290
Lines 97293 97317 +24
Branches 3280 3280
============================================
- Hits 38100 38079 -21
- Misses 57254 57299 +45
Partials 1939 1939
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job !
d6c7f46
to
6f51c31
Compare
6f51c31
to
2d8b3af
Compare
front/src/common/SpeedLimitByTagSelector/useStoreDataForSpeedLimitByTagSelector.ts
Outdated
Show resolved
Hide resolved
2d8b3af
to
695d55a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the back-and-forth, LGTM :)
Signed-off-by: theocrsb <[email protected]>
0379293
to
03b3279
Compare
closes #9311
closes #8729