Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: handle accents in STDCM vias autocomplete #9333

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

leovalais
Copy link
Contributor

No description provided.

@leovalais leovalais requested a review from a team as a code owner October 14, 2024 14:49
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 39.14%. Comparing base (3ac680e) to head (93ed630).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/utils/strings.ts 37.50% 5 Missing ⚠️
...tions/stdcmV2/components/StdcmOperationalPoint.tsx 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9333      +/-   ##
============================================
- Coverage     39.16%   39.14%   -0.03%     
  Complexity     2245     2245              
============================================
  Files          1290     1290              
  Lines         97268    97293      +25     
  Branches       3280     3280              
============================================
- Hits          38097    38083      -14     
- Misses        57232    57271      +39     
  Partials       1939     1939              
Flag Coverage Δ
core 74.94% <ø> (ø)
editoast 72.41% <ø> (-0.08%) ⬇️
front 10.33% <30.00%> (+<0.01%) ⬆️
gateway 2.50% <ø> (ø)
osrdyne 3.52% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks ! 💯

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, thank you !

@leovalais leovalais force-pushed the lva/handle-accents-stdcm-autocomplete branch from 385c91d to 93ed630 Compare October 15, 2024 11:55
@leovalais leovalais enabled auto-merge October 15, 2024 11:56
@leovalais leovalais added this pull request to the merge queue Oct 15, 2024
Merged via the queue into dev with commit 1f3cac3 Oct 15, 2024
24 checks passed
@leovalais leovalais deleted the lva/handle-accents-stdcm-autocomplete branch October 15, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants