Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: spaceTimeChart: display occupancy blocks #9366

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Akctarus
Copy link
Contributor

closes #9365

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 44.89796% with 27 lines in your changes missing coverage. Please review.

Project coverage is 39.06%. Comparing base (74968f6) to head (6a5d578).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
...WithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx 0.00% 17 Missing ⚠️
...ents/ManchetteWithSpaceTimeChart/SettingsPanel.tsx 0.00% 9 Missing ⚠️
front/src/modules/simulationResult/types.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9366      +/-   ##
============================================
- Coverage     39.06%   39.06%   -0.01%     
  Complexity     2270     2270              
============================================
  Files          1308     1308              
  Lines         99315    99361      +46     
  Branches       3316     3316              
============================================
+ Hits          38800    38813      +13     
- Misses        58550    58583      +33     
  Partials       1965     1965              
Flag Coverage Δ
core 74.99% <ø> (+<0.01%) ⬆️
editoast 71.87% <ø> (-0.04%) ⬇️
front 10.35% <44.89%> (+0.03%) ⬆️
gateway 2.50% <ø> (ø)
osrdyne 3.29% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/front/display-occupancy-blocks branch 3 times, most recently from d6660e6 to d6f94d9 Compare October 19, 2024 14:49
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Oct 19, 2024
@Akctarus Akctarus force-pushed the tmn/front/display-occupancy-blocks branch 2 times, most recently from 88daeca to 5a848c3 Compare October 19, 2024 15:35
@github-actions github-actions bot removed the area:editoast Work on Editoast Service label Oct 19, 2024
@Akctarus Akctarus force-pushed the tmn/front/display-occupancy-blocks branch from d3c5b60 to f62717e Compare October 19, 2024 21:49
@Akctarus Akctarus marked this pull request as ready for review October 19, 2024 21:49
@Akctarus Akctarus requested a review from a team as a code owner October 19, 2024 21:49
@Akctarus Akctarus force-pushed the tmn/front/display-occupancy-blocks branch 6 times, most recently from 83e1102 to 45f1db3 Compare October 22, 2024 07:42
@Akctarus Akctarus requested review from emersion and theocrsb October 23, 2024 08:56
@emersion
Copy link
Member

@flomonster's comment remains to be fixed: we're still relying on a field meant to be displayed to the user, not something meant to be stable. If we want to merge this quickly, I'd suggest opening a follow-up issue.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to resolve remaining comments and merge :)

@Akctarus Akctarus force-pushed the tmn/front/display-occupancy-blocks branch 2 times, most recently from c031e84 to 4da0808 Compare October 23, 2024 20:58
@Akctarus Akctarus enabled auto-merge October 23, 2024 20:59
@Akctarus Akctarus force-pushed the tmn/front/display-occupancy-blocks branch 2 times, most recently from 530004f to 29d7353 Compare October 23, 2024 21:01
@Akctarus Akctarus force-pushed the tmn/front/display-occupancy-blocks branch from 29d7353 to 6a5d578 Compare October 24, 2024 08:11
@Akctarus Akctarus added this pull request to the merge queue Oct 24, 2024
Merged via the queue into dev with commit 7451939 Oct 24, 2024
24 checks passed
@Akctarus Akctarus deleted the tmn/front/display-occupancy-blocks branch October 24, 2024 10:01
@Akctarus Akctarus removed the request for review from theocrsb October 28, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: space time chart: display occupancy blocks
5 participants