-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: spaceTimeChart: display occupancy blocks #9366
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9366 +/- ##
============================================
- Coverage 39.06% 39.06% -0.01%
Complexity 2270 2270
============================================
Files 1308 1308
Lines 99315 99361 +46
Branches 3316 3316
============================================
+ Hits 38800 38813 +13
- Misses 58550 58583 +33
Partials 1965 1965
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d6660e6
to
d6f94d9
Compare
88daeca
to
5a848c3
Compare
d3c5b60
to
f62717e
Compare
83e1102
to
45f1db3
Compare
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
@flomonster's comment remains to be fixed: we're still relying on a field meant to be displayed to the user, not something meant to be stable. If we want to merge this quickly, I'd suggest opening a follow-up issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to resolve remaining comments and merge :)
c031e84
to
4da0808
Compare
530004f
to
29d7353
Compare
Signed-off-by: Theo Macron <[email protected]>
29d7353
to
6a5d578
Compare
closes #9365