Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix flaky test with hardcoded ID #9527

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Oct 31, 2024

The actual ID would depend on the state of the DB, it gets incremented whenever a work schedule is added

The actual ID would depend on the state of the DB, it
gets incremented whenever a work schedule is added

Signed-off-by: Eloi Charpentier <[email protected]>
@eckter eckter requested a review from shenriotpro October 31, 2024 10:18
@eckter eckter requested a review from a team as a code owner October 31, 2024 10:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.64%. Comparing base (6d9ed21) to head (2dfbdce).
Report is 14 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9527      +/-   ##
============================================
- Coverage     39.65%   39.64%   -0.01%     
  Complexity     2270     2270              
============================================
  Files          1300     1300              
  Lines         99079    99081       +2     
  Branches       3279     3279              
============================================
- Hits          39286    39277       -9     
- Misses        57864    57875      +11     
  Partials       1929     1929              
Flag Coverage Δ
core 75.06% <ø> (ø)
editoast 73.28% <ø> (-0.04%) ⬇️
front 10.22% <ø> (ø)
gateway 2.19% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@eckter eckter added this pull request to the merge queue Nov 4, 2024
Merged via the queue into dev with commit 5eeb926 Nov 4, 2024
24 checks passed
@eckter eckter deleted the ech/fix-flaky-int-test branch November 4, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants