Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: units comments and better variable name #9552

Merged

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Nov 4, 2024

fix #9528

Some improvements for stdcm consist

  • Add units comments
  • Rename carriage_mass to towed_mass in stdcm consist

@Wadjetz Wadjetz self-assigned this Nov 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.52%. Comparing base (5eeb926) to head (97eeee8).
Report is 14 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9552      +/-   ##
============================================
- Coverage     39.52%   39.52%   -0.01%     
  Complexity     2270     2270              
============================================
  Files          1309     1309              
  Lines        100244   100244              
  Branches       3295     3295              
============================================
- Hits          39622    39617       -5     
- Misses        58677    58682       +5     
  Partials       1945     1945              
Flag Coverage Δ
core 75.06% <ø> (ø)
editoast 73.56% <100.00%> (-0.02%) ⬇️
front 10.10% <ø> (ø)
gateway 2.19% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz force-pushed the ebe/editoast/stdcm-convoi-better-var-name-and-units-comments branch from 838b5f5 to 97eeee8 Compare November 4, 2024 14:42
@Wadjetz Wadjetz marked this pull request as ready for review November 5, 2024 09:26
@Wadjetz Wadjetz requested a review from a team as a code owner November 5, 2024 09:26
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the follow-up.

@Wadjetz Wadjetz added this pull request to the merge queue Nov 5, 2024
Merged via the queue into dev with commit 9144c4e Nov 5, 2024
24 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast/stdcm-convoi-better-var-name-and-units-comments branch November 5, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing points for consists
4 participants