-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: error message for non-recognized points in pathfinding #9568
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9568 +/- ##
============================================
+ Coverage 39.52% 42.49% +2.96%
- Complexity 2270 2271 +1
============================================
Files 1309 1311 +2
Lines 100242 105431 +5189
Branches 3295 3297 +2
============================================
+ Hits 39618 44800 +5182
- Misses 58679 58685 +6
- Partials 1945 1946 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We now lose the markers and the path on the map. I think we should keep this behavior. |
aa70d66
to
1badc43
Compare
1badc43
to
4f3239c
Compare
4f3239c
to
9dbbe51
Compare
When going in itinerary, markers aren't displayed in the map when orign or destination is invalid.
There is maybe a better way to do it but we have the markers in the map then. |
9dbbe51
to
6c44680
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (tested)
front/src/modules/pathfinding/components/Pathfinding/Pathfinding.tsx
Outdated
Show resolved
Hide resolved
9d3391f
to
5288d66
Compare
front/src/modules/pathfinding/components/Pathfinding/Pathfinding.tsx
Outdated
Show resolved
Hide resolved
5288d66
to
5028bd0
Compare
Signed-off-by: Achraf Mohyeddine <[email protected]>
5028bd0
to
21f2679
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #9520