Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add CLI to import towed rolling stock #9580

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

woshilapin
Copy link
Contributor

Closes #8668

This new CLI brings a simple way to import Towed rolling stock in the DB from JSON files, without the need to start the editoast web service.

@woshilapin woshilapin requested a review from a team as a code owner November 5, 2024 16:32
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.53%. Comparing base (0e1ea9b) to head (d838e73).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/client/import_rolling_stock.rs 97.91% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9580      +/-   ##
============================================
+ Coverage     42.51%   42.53%   +0.02%     
  Complexity     2271     2271              
============================================
  Files          1311     1311              
  Lines        105413   105444      +31     
  Branches       3297     3297              
============================================
+ Hits          44812    44849      +37     
+ Misses        58655    58649       -6     
  Partials       1946     1946              
Flag Coverage Δ
core 75.05% <ø> (ø)
editoast 73.75% <97.91%> (+0.04%) ⬆️
front 18.79% <ø> (ø)
gateway 2.19% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woshilapin woshilapin force-pushed the wsl/editoast/cli-towed branch from dbe9235 to 9182235 Compare November 5, 2024 17:02
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

editoast/src/client/import_rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/client/import_rolling_stock.rs Outdated Show resolved Hide resolved
@woshilapin woshilapin force-pushed the wsl/editoast/cli-towed branch from f582efe to d838e73 Compare November 7, 2024 10:28
@woshilapin woshilapin enabled auto-merge November 7, 2024 10:28
@woshilapin woshilapin added this pull request to the merge queue Nov 7, 2024
Merged via the queue into dev with commit b74fd59 Nov 7, 2024
24 checks passed
@woshilapin woshilapin deleted the wsl/editoast/cli-towed branch November 7, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the import of RollstocksJson into editoast
3 participants