front: fix last waypoints hidden with warning #9592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a padding-bottom to the waypoints panel body when the warning message is displayed, allowing the last waypoints from the manchette not to be hidden by it Signed-off-by: SharglutDev <[email protected]>
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9592 +/- ##
============================================
- Coverage 39.56% 39.55% -0.02%
Complexity 2271 2271
============================================
Files 1309 1309
Lines 100257 100260 +3
Branches 3296 3296
============================================
- Hits 39669 39656 -13
- Misses 58642 58658 +16
Partials 1946 1946
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kmer2016
approved these changes
Nov 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
SharglutDev
deleted the
pfn/front/fix-last-waypoints-panel-position-with-warning
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a padding-bottom to the waypoints panel body when the warning message is displayed, allowing the last waypoints from the manchette not to be hidden by it
fix last bug mentionned here #8628 (comment)
To display the warning message, there need to be less than 2 waypoints checked in the panel