Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: allow LongString in the x-rpc-path header #9596

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Nov 6, 2024

The RabbitMQ management client doesn't allow us to set the headers as bytes, so we should be more lenient as to the received data type.

@Khoyo Khoyo requested a review from a team as a code owner November 6, 2024 14:06
@Khoyo Khoyo requested a review from Erashin November 6, 2024 14:06
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 42.50%. Comparing base (cd3935d) to head (3347028).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...re/src/main/java/fr/sncf/osrd/cli/WorkerCommand.kt 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9596      +/-   ##
============================================
- Coverage     42.51%   42.50%   -0.01%     
  Complexity     2271     2271              
============================================
  Files          1311     1311              
  Lines        105408   105410       +2     
  Branches       3296     3297       +1     
============================================
- Hits          44813    44805       -8     
- Misses        58649    58659      +10     
  Partials       1946     1946              
Flag Coverage Δ
core 75.05% <0.00%> (-0.02%) ⬇️
editoast 73.67% <ø> (-0.03%) ⬇️
front 18.79% <ø> (ø)
gateway 2.19% <ø> (ø)
osrdyne 3.28% <ø> (+<0.01%) ⬆️
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The RabbitMQ management client doesn't allow us to set the headers as
bytes, so we should be more lenient as to the received data type.

Signed-off-by: Younes Khoudli <[email protected]>
@Khoyo Khoyo force-pushed the yk/core-header-longstring branch from 1f69eb9 to 3347028 Compare November 6, 2024 14:08
@Khoyo Khoyo enabled auto-merge November 6, 2024 15:04
@Khoyo Khoyo added this pull request to the merge queue Nov 6, 2024
Merged via the queue into dev with commit a89bb0e Nov 6, 2024
24 checks passed
@Khoyo Khoyo deleted the yk/core-header-longstring branch November 6, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants