Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: support macos and improve readibility #9615

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

ElysaSrc
Copy link
Member

@ElysaSrc ElysaSrc commented Nov 7, 2024

No description provided.

@ElysaSrc ElysaSrc requested a review from a team as a code owner November 7, 2024 09:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.50%. Comparing base (00a169a) to head (337c478).
Report is 21 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9615      +/-   ##
============================================
+ Coverage     39.56%   42.50%   +2.93%     
  Complexity     2271     2271              
============================================
  Files          1309     1311       +2     
  Lines        100257   105413    +5156     
  Branches       3296     3297       +1     
============================================
+ Hits          39669    44803    +5134     
- Misses        58642    58664      +22     
  Partials       1946     1946              
Flag Coverage Δ
core 75.05% <ø> (-0.02%) ⬇️
editoast 73.67% <ø> (-0.04%) ⬇️
front 18.79% <ø> (+8.68%) ⬆️
gateway 2.19% <ø> (ø)
osrdyne 3.28% <ø> (+<0.01%) ⬆️
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not tested not a nix user

@ElysaSrc ElysaSrc enabled auto-merge November 7, 2024 10:00
@ElysaSrc ElysaSrc added this pull request to the merge queue Nov 7, 2024
Merged via the queue into dev with commit 46990cb Nov 7, 2024
24 checks passed
@ElysaSrc ElysaSrc deleted the ev/fix-macos-flake branch November 7, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants