Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: handle stops in viriato imports #9725

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

RomainValls
Copy link
Contributor

closes #9641

You can ask me to send you the test files by message

Now, when a step has an arrival and departure time, the calculated difference is used for the stop duration.

@RomainValls RomainValls requested a review from a team as a code owner November 15, 2024 11:28
@RomainValls
Copy link
Contributor Author

RomainValls commented Nov 15, 2024

You might notice that, for some steps (in this test file, it happens a lot with the step "Veynes"), we have a step duplicate in the TimeStopsInput and the TimeStopsOutput. This causes the second duplicated value to be valued at day+1.
I don't think it's related to the viriato import as it also happens when creating the train manually.
I'll open a new issue about it.

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested good work

@RomainValls RomainValls self-assigned this Nov 18, 2024
@RomainValls RomainValls requested a review from emersion November 18, 2024 10:26
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.83%. Comparing base (52c374b) to head (e8e8831).
Report is 18 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9725      +/-   ##
==========================================
- Coverage   79.84%   79.83%   -0.01%     
==========================================
  Files        1048     1048              
  Lines      105055   105056       +1     
  Branches      756      756              
==========================================
- Hits        83885    83876       -9     
- Misses      21129    21139      +10     
  Partials       41       41              
Flag Coverage Δ
editoast 73.33% <ø> (-0.04%) ⬇️
front 89.34% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomainValls RomainValls force-pushed the rvs/front-handle-stops-in-viriato-imports branch from 91a31c0 to 9280d0e Compare November 20, 2024 15:34
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 26, 2024
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from these LGTM!

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM regardless (feel free to resolve comment)!

@RomainValls RomainValls force-pushed the rvs/front-handle-stops-in-viriato-imports branch 2 times, most recently from 8b332f6 to 0887856 Compare December 5, 2024 12:59
@RomainValls RomainValls force-pushed the rvs/front-handle-stops-in-viriato-imports branch from 0887856 to e8e8831 Compare December 5, 2024 12:59
@RomainValls RomainValls added this pull request to the merge queue Dec 6, 2024
Merged via the queue into dev with commit 938dd3d Dec 6, 2024
27 checks passed
@RomainValls RomainValls deleted the rvs/front-handle-stops-in-viriato-imports branch December 6, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viriato import doesn't handle stops
5 participants