-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: handle stops in viriato imports #9725
Conversation
You might notice that, for some steps (in this test file, it happens a lot with the step "Veynes"), we have a step duplicate in the TimeStopsInput and the TimeStopsOutput. This causes the second duplicated value to be valued at day+1. |
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested good work
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9725 +/- ##
==========================================
- Coverage 79.84% 79.83% -0.01%
==========================================
Files 1048 1048
Lines 105055 105056 +1
Branches 756 756
==========================================
- Hits 83885 83876 -9
- Misses 21129 21139 +10
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
91a31c0
to
9280d0e
Compare
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from these LGTM!
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM regardless (feel free to resolve comment)!
8b332f6
to
0887856
Compare
Signed-off-by: romainvalls <[email protected]>
0887856
to
e8e8831
Compare
closes #9641
You can ask me to send you the test files by message
Now, when a step has an arrival and departure time, the calculated difference is used for the stop duration.