Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: remove trigram from stdcmPathstep #9749

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

SarahBellaha
Copy link
Contributor

Closes #9745

@SarahBellaha SarahBellaha requested a review from a team as a code owner November 18, 2024 09:15
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 37.82%. Comparing base (b4b2d7f) to head (d2630f4).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/reducers/osrdconf/stdcmConf/index.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9749      +/-   ##
==========================================
- Coverage   37.84%   37.82%   -0.02%     
==========================================
  Files         990      990              
  Lines       90921    90920       -1     
  Branches     1176     1176              
==========================================
- Hits        34412    34395      -17     
- Misses      56055    56071      +16     
  Partials      454      454              
Flag Coverage Δ
editoast 73.21% <ø> (-0.06%) ⬇️
front 20.11% <0.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove trigram from StdcmLinkedPathStep as well?

@emersion
Copy link
Member

Ah, seems like we shouldn't, because it's used in the UI in StdcmLinkedPathResults.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested

@SarahBellaha SarahBellaha added this pull request to the merge queue Nov 18, 2024
Merged via the queue into dev with commit 9109693 Nov 18, 2024
27 checks passed
@SarahBellaha SarahBellaha deleted the sba/front/lmr-fix-wrong-trigram branch November 18, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STDCM - Input CI not coherent with the input
4 participants