front: switch oazapfts fork to osrd-project repository #9784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two issues:
- The commit of anisometropie/oazapfts that we were using was not
in any branch. The master branch has been forced pushed to. This
makes it tricky to browse the code actually used in OSRD, and the
commit may be GC'ed since it's unreachable.
- The "prepare" script was running after installation, even though
the fork has the built artifacts checked in. This is unnecessary
and causes issues with NPM ("husky" wants a .git directory, it's
there with yarn but NPM strips it).
Additionally, a fork in a personal repository makes it difficult
for others to push fixes.
Signed-off-by: Simon Ser <[email protected]>
anisometropie
approved these changes
Nov 20, 2024
Yohh
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues:
Additionally, a fork in a personal repository makes it difficult for others to push fixes.
(Alternatively, we could decide to just switch to upstream oazapfts, since we don't use the buggy type.)