Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: edit timetable trains in macro mode #9816

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

RomainValls
Copy link
Contributor

Part 2 of https://github.com/osrd-project/osrd-confidential/issues/840

We can now :

  • edit trains from the timetable in macro mode and see the update
  • edit trains from NGE and see the updates in the timetable train card

@RomainValls RomainValls added area:front Work on Standard OSRD Interface modules component:nge Macroscopic mode of Operational Studies module labels Nov 21, 2024
@RomainValls RomainValls self-assigned this Nov 21, 2024
@RomainValls RomainValls requested a review from a team as a code owner November 21, 2024 16:59
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.87%. Comparing base (d9626c4) to head (434223e).
Report is 10 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9816      +/-   ##
==========================================
- Coverage   79.88%   79.87%   -0.02%     
==========================================
  Files        1048     1048              
  Lines      105241   105238       -3     
  Branches      756      756              
==========================================
- Hits        84072    84059      -13     
- Misses      21128    21138      +10     
  Partials       41       41              
Flag Coverage Δ
editoast 73.42% <ø> (-0.04%) ⬇️
front 89.36% <100.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomainValls RomainValls force-pushed the rvs/front-edit-timetable-trains-in-macro-mode branch from b051b74 to 361e9b2 Compare November 21, 2024 17:03
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, good work

@RomainValls RomainValls force-pushed the rvs/front-edit-timetable-trains-in-macro-mode branch 3 times, most recently from ce53488 to 40ccfd9 Compare November 29, 2024 12:14
@RomainValls RomainValls force-pushed the rvs/front-edit-timetable-trains-in-macro-mode branch 2 times, most recently from ff72c68 to b2b3224 Compare December 9, 2024 17:40
@RomainValls RomainValls requested a review from emersion December 10, 2024 11:05
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@RomainValls RomainValls force-pushed the rvs/front-edit-timetable-trains-in-macro-mode branch from 5e74043 to 928a713 Compare December 10, 2024 11:40
@RomainValls RomainValls force-pushed the rvs/front-edit-timetable-trains-in-macro-mode branch from 928a713 to 434223e Compare December 10, 2024 11:47
@RomainValls RomainValls added this pull request to the merge queue Dec 10, 2024
Merged via the queue into dev with commit f354aff Dec 10, 2024
27 checks passed
@RomainValls RomainValls deleted the rvs/front-edit-timetable-trains-in-macro-mode branch December 10, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules component:nge Macroscopic mode of Operational Studies module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants