Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: rem to px in /common #9842

Merged
merged 8 commits into from
Nov 26, 2024
Merged

front: rem to px in /common #9842

merged 8 commits into from
Nov 26, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Nov 25, 2024

closes #9841

@clarani clarani requested a review from a team as a code owner November 25, 2024 14:59
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.21%. Comparing base (e1bc706) to head (fbdca28).
Report is 8 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9842      +/-   ##
==========================================
- Coverage   38.22%   38.21%   -0.01%     
==========================================
  Files         995      995              
  Lines       91893    91893              
  Branches     1189     1189              
==========================================
- Hits        35128    35119       -9     
- Misses      56311    56320       +9     
  Partials      454      454              
Flag Coverage Δ
editoast 73.30% <ø> (-0.03%) ⬇️
front 20.23% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/9841-rem-to-px-common branch from 6301840 to 50d5d17 Compare November 25, 2024 16:24
@clarani clarani force-pushed the cni/9841-rem-to-px-common branch from 50d5d17 to e91c9cf Compare November 25, 2024 16:40
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@clarani clarani added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@clarani clarani added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@clarani clarani force-pushed the cni/9841-rem-to-px-common branch from a5b9d70 to fbdca28 Compare November 26, 2024 17:30
@clarani clarani enabled auto-merge November 26, 2024 17:30
@clarani clarani added this pull request to the merge queue Nov 26, 2024
Merged via the queue into dev with commit e1bb669 Nov 26, 2024
28 checks passed
@clarani clarani deleted the cni/9841-rem-to-px-common branch November 26, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: convert rem to px in /common
4 participants