front: fix margin around scenario simulation results scrollbar #9869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theocrsb
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Navbar size varies according to screen size. If we choose one or the other, a scrollbar appears.
It might be better to set the navbar size to 40px (as seen with @thibautsailly).
emersion
force-pushed
the
emr/scenario-scroll-layout
branch
from
ac0c046 to
1556ea9
Compare
|
I've dropped the first commit which changes the navbar size. I'll fix it separately. |
emersion
changed the title
emersion
force-pushed
the
emr/scenario-scroll-layout
branch
from
1556ea9 to
a4bc495
Compare
emersion
force-pushed
the
emr/scenario-scroll-layout
branch
2 times, most recently
from
11aa32b to
fbcfd06
Compare
The scrollbar was displayed with a margin on the right. Multiple issues here: - Two elements had the same "scenario-sidemenu" CSS class. - A CSS rule was overwriting Bootstrap's paddings for one column, but this messes up the layout because other columns weren't adjusted to take up more space. Use "no-gutters" instead, which is designed specifically for this use-case. - Drop the min/max widths for the train list, because this creates a weird blank space for some screen sizes. Leave it up to the parent column to pick a reasonable width. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/scenario-scroll-layout
branch
from
fbcfd06 to
e477866
Compare
Maymanaf
approved these changes
Dec 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple issues here:
but this messes up the layout because other columns weren't
adjusted to take up more space. Use "no-gutters" instead, which
is designed specifically for this use-case.
a weird blank space for some screen sizes. Leave it up to the
parent column to pick a reasonable width.
Before:
After: