Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix map marker offset #9871

Merged
merged 1 commit into from
Dec 3, 2024
Merged

front: fix map marker offset #9871

merged 1 commit into from
Dec 3, 2024

Conversation

emersion
Copy link
Member

Set the offset prop to define the image "hotspot" (ie, pixel coordinate where the sign is planted on).

Closes: #9633

@emersion emersion requested a review from a team as a code owner November 26, 2024 16:32
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 26, 2024
Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (tested)

Set the `offset` prop to define the image "hotspot" (ie, pixel
coordinate where the sign is planted on).

Signed-off-by: Simon Ser <[email protected]>
Closes: #9633
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested. Feel free to solve the comment whether you fix it or not :)

@emersion emersion added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@emersion emersion added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@emersion emersion added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@emersion emersion added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@emersion emersion added this pull request to the merge queue Dec 3, 2024
Merged via the queue into dev with commit 7f31f82 Dec 3, 2024
27 checks passed
@emersion emersion deleted the emr/marker-offset branch December 3, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual offset between the pointers and the track on the map
4 participants