-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix map marker offset #9871
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
commented
Nov 26, 2024
front/src/modules/simulationResult/components/SimulationResultsMap/RenderItinerary.tsx
Outdated
Show resolved
Hide resolved
emersion
force-pushed
the
emr/marker-offset
branch
from
November 26, 2024 16:35
eabc327
to
bd72229
Compare
Caracol3
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (tested)
Set the `offset` prop to define the image "hotspot" (ie, pixel coordinate where the sign is planted on). Signed-off-by: Simon Ser <[email protected]> Closes: #9633
emersion
force-pushed
the
emr/marker-offset
branch
from
November 29, 2024 15:15
bd72229
to
f732246
Compare
SharglutDev
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested. Feel free to solve the comment whether you fix it or not :)
front/src/modules/simulationResult/components/SimulationResultsMap/RenderItinerary.tsx
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the
offset
prop to define the image "hotspot" (ie, pixel coordinate where the sign is planted on).Closes: #9633