Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: simplify usePathfinding #9901

Merged
merged 3 commits into from
Dec 3, 2024
Merged

front: simplify usePathfinding #9901

merged 3 commits into from
Dec 3, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Nov 29, 2024

closes #9900

see commits

@clarani clarani requested a review from a team as a code owner November 29, 2024 09:08
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 10.58824% with 152 lines in your changes missing coverage. Please review.

Project coverage is 38.19%. Comparing base (c98d385) to head (0a7e029).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
...nt/src/modules/pathfinding/hooks/usePathfinding.ts 0.00% 128 Missing ⚠️
...ront/src/reducers/osrdconf/osrdConfCommon/index.ts 66.66% 9 Missing ⚠️
...inding/components/Itinerary/ModalSuggestedVias.tsx 0.00% 4 Missing ⚠️
...les/pathfinding/components/Itinerary/Itinerary.tsx 0.00% 3 Missing ⚠️
...pathfinding/components/Pathfinding/TypeAndPath.tsx 0.00% 2 Missing ⚠️
front/src/modules/pathfinding/utils.ts 0.00% 2 Missing ⚠️
...rainSchedule/ManageTrainScheduleMap/setPointIti.ts 0.00% 2 Missing ⚠️
...alStudies/hooks/useSetupItineraryForTrainUpdate.ts 0.00% 1 Missing ⚠️
front/src/modules/timesStops/TimesStopsInput.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9901      +/-   ##
==========================================
- Coverage   38.19%   38.19%   -0.01%     
==========================================
  Files         998      997       -1     
  Lines       92197    92202       +5     
  Branches     1192     1191       -1     
==========================================
- Hits        35219    35214       -5     
- Misses      56522    56532      +10     
  Partials      456      456              
Flag Coverage Δ
editoast 73.37% <ø> (-0.02%) ⬇️
front 20.17% <10.58%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/9900-simplify-pathfinding branch from c75f9f4 to c0fa560 Compare November 29, 2024 09:18
@clarani clarani enabled auto-merge November 29, 2024 13:16
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Everything seems to be still working !

Some new actions are a bit strange but I guess it's the first step of your pathfinding refacto ? :)

front/src/reducers/osrdconf/osrdConfCommon/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :)

@clarani clarani force-pushed the cni/9900-simplify-pathfinding branch from 6115d6a to e57c515 Compare December 2, 2024 16:43
Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! That’s a really great improvement on the redux part. that’s really the direction we should take for our usage of redux, calling actions replaceItinerary and reverseItinerary emphasis the business rules we’re trying to implement instead of justupdateSomeElement we have been doing so far in all our reducers

Split startPathFinding into 2 functions and reorganize the code.
No functional change.

Signed-off-by: Clara Ni <[email protected]>
Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@clarani clarani added this pull request to the merge queue Dec 3, 2024
Merged via the queue into dev with commit a89f540 Dec 3, 2024
27 checks passed
@clarani clarani deleted the cni/9900-simplify-pathfinding branch December 3, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: simplify usePathfinding
4 participants