-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: simplify usePathfinding #9901
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9901 +/- ##
==========================================
- Coverage 38.19% 38.19% -0.01%
==========================================
Files 998 997 -1
Lines 92197 92202 +5
Branches 1192 1191 -1
==========================================
- Hits 35219 35214 -5
- Misses 56522 56532 +10
Partials 456 456
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c75f9f4
to
c0fa560
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. Everything seems to be still working !
Some new actions are a bit strange but I guess it's the first step of your pathfinding
refacto ? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm :)
Signed-off-by: Clara Ni <[email protected]>
6115d6a
to
e57c515
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! That’s a really great improvement on the redux part. that’s really the direction we should take for our usage of redux, calling actions replaceItinerary
and reverseItinerary
emphasis the business rules we’re trying to implement instead of justupdateSomeElement
we have been doing so far in all our reducers
Signed-off-by: Clara Ni <[email protected]>
Split startPathFinding into 2 functions and reorganize the code. No functional change. Signed-off-by: Clara Ni <[email protected]>
e57c515
to
0a7e029
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested
closes #9900
see commits