Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: etcs: move files to envelope_sim module #9929

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Dec 3, 2024

Avoids circular dependencies with envelope_sim

@eckter eckter requested a review from a team as a code owner December 3, 2024 14:07
@eckter eckter requested a review from Erashin December 3, 2024 14:07
@github-actions github-actions bot added the area:core Work on Core Service label Dec 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.20%. Comparing base (9dedb37) to head (ba1bc5f).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9929      +/-   ##
==========================================
- Coverage   38.21%   38.20%   -0.01%     
==========================================
  Files         992      992              
  Lines       92158    92158              
  Branches     1186     1186              
==========================================
- Hits        35217    35211       -6     
- Misses      56490    56496       +6     
  Partials      451      451              
Flag Coverage Δ
editoast 73.36% <ø> (-0.02%) ⬇️
front 20.18% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/move-etcs-files branch from 015ec58 to a85257a Compare December 3, 2024 14:14
@eckter eckter force-pushed the ech/move-etcs-files branch from a85257a to ba1bc5f Compare December 3, 2024 14:18
@eckter eckter enabled auto-merge December 3, 2024 14:29
@eckter eckter added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@eckter eckter added this pull request to the merge queue Dec 3, 2024
Merged via the queue into dev with commit 02ccfc8 Dec 3, 2024
27 checks passed
@eckter eckter deleted the ech/move-etcs-files branch December 3, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants